-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide Ministry Ability to Edit Student Basic BCeID Profile Info #3222
Comments
Additional information to consider: As a Ministry User I can not distinct between BasicBCeID and BC Services Student account once they are created. BC Services student account profile updates must be directed to Service BC and BasicBCeID dealt in the house. How as a Ministry User I can tell which case I am dealing with? Confirm with student verbally? Can information be conveyed by SIMS instead? |
@AnnaPBashkatova - You're right, however there is some way to distinguish --- the Ministry user can search through JIRA history to see if a ticket was created when this student initially requested account creation. Given there is an alternative way of accomplishing this task - however unpleasant - I would deem your suggestion as 'non-critical' for MVP. That being said, can you please log a quick barebones ticket to capture that nuance, and we can discuss and triage to a post-MVP release? |
@JerPearson @CarlyCotton While updating first name, last name, or DBO we also trigger a new SIN validation. |
@andrewsignori-aot Thank you - I've added business context and an AC to treat this similarly to the BCSC process that happens already. |
@CarlyCotton @JerPearson When the student is authenticating using BCSC the profile date is checked and it will be updated if the name or DOB is changed. For the Ministry editing the basic BCeID we are now saving a note to the student's notes, can we do the same for the BCSC update already in place? |
I think that's a great idea. Would be very helpful for staff and aligns the outcomes for both paths. |
Thank You @andrewsignori-aot and @JerPearson. Code updated accordingly. |
…#3770) ### As a part of this PR, the following were completed: **Business Requirements Completed:** - Enabled ministry user the ability to edit the profile details of a Basic BCeID student's account **(Given Names, Last name, DOB, and email)**. - Added a General Note for this profile information update. - Treated the update like a personal information change from BCSC logins and did a new SIN verification for any DOB, Given name, or Last name (ensuring that the match of the information is not case-sensitive). - Replicated the role for account approval of Basic BCeID and created a new one for this scenario. - Updated the roles spreadsheet. **Technical Requirements Completed:** - Created an edit button and a model that opens on clicking the edit button to allows for the update of the 4 fields (Given Names, Last name, DOB, and Email). All fields except **GivenNames** are mandatory. - Added a General Note for the same. - Applied the same validations from the student profile for the validations of the user fields in the modal. `GivenName` is empty and therefore, will not throw any validation error and can be persisted as an empty field. - To achieve the above, created a new endpoint PATCH `aest/student/:studentId`. Performed the validation if the student is a BCeID student and also validated the user fields and added the same role (`student-edit-profile`) to this endpoint. **Note:** I tried using the `v-date-input` for the Date component in the modal but it is a lab component and I ran into issues with using this component. Issues, for instance, `clearable` not clearing the field etc. Therefore, I have used the regular `v-text-field` with the `type=date`. **e2e tests will be part of the next PR.** ### Screenshots - **Edit Profile button for the Basic BCeID student** <img width="1920" alt="image" src="https://github.com/user-attachments/assets/d1963de0-753e-43bd-8da5-bf8828198569"> ------------------------------------------------------------------------------------------------------- - **Edit Profile Modal** <img width="1920" alt="image" src="https://github.com/user-attachments/assets/f2fe7dca-a626-4a7a-b18f-30e974c93080"> ------------------------------------------------------------------------------------------------------- - **Validations for the Edit Profile Modal** <img width="1919" alt="image" src="https://github.com/user-attachments/assets/d3758f37-7783-4a9a-ade2-fa891c3688a6"> ------------------------------------------------------------------------------------------------------- - **Date Validation not showing the date beyond the today's date for the date of birth** <img width="1920" alt="image" src="https://github.com/user-attachments/assets/d6f01bd8-c7e7-4f68-a3a1-3d9012e8afa0"> ------------------------------------------------------------------------------------------------------- - **Empty Given Names does not throw any validation error.** <img width="1920" alt="image" src="https://github.com/user-attachments/assets/3aae06f3-b832-4f99-befb-dedd997492a0"> ------------------------------------------------------------------------------------------------------- - **`Snackbar` showing the update after the successful update** <img width="1920" alt="image" src="https://github.com/user-attachments/assets/fae4c34a-c574-46da-ace2-5a4e4d0268ed"> ------------------------------------------------------------------------------------------------------- - **`Snackbar` showing the error message if an error happens for any reason during the student profile update** <img width="1920" alt="image" src="https://github.com/user-attachments/assets/e6fa2a5e-ef00-4c23-bc3c-3e454d093f44"> ------------------------------------------------------------------------------------------------------- - **Added Notes in the General section** <img width="1919" alt="image" src="https://github.com/user-attachments/assets/77fba118-4cc8-41f4-bda1-ce508e7cd229"> ------------------------------------------------------------------------------------------------------- - **Processing loader while the information is being updated** <img width="1920" alt="image" src="https://github.com/user-attachments/assets/bb54ab5c-2cf4-4cb7-ac4c-6782f12facac"> ------------------------------------------------------------------------------------------------------- - **Edit Profile button not shown for any non Basic BCeID user** <img width="1920" alt="image" src="https://github.com/user-attachments/assets/f46c7392-a04a-4d63-9d8e-fd2f8811777f">
… (e2e tests) (#3794) ### As a part of this PR, the following e2e tests were written: `StudentAESTController(e2e)-updateProfileInformation` √ Should allow the student profile update when the student is a Basic BCeID user. (5472 ms) √ Should throw an HTTP Unprocessable Entity (422) error when the student is not a Basic BCeID user. (2619 ms) √ Should throw an HTTP Forbidden (403) error when the ministry user performing the profile update does not have the associated role. (497 ms) √ Should throw an HTTP Unprocessable Entity (422) error when the student is a Basic BCeID user but none of the user profile information that needs to be updated has changed. (3076 ms) √ Should throw an HTTP Not Found (404) error when the student does not exist. (514 ms) √ Should throw an HTTP Bad Request error when some mandatory profile update information is missing from the payload. (7 ms) √ Should allow the student profile update when the student is a Basic BCeID user and the givenNames is not provided. (4945 ms) ### Screenshot of the passed e2e tests: <img width="1244" alt="image" src="https://github.com/user-attachments/assets/32d19cac-be2c-477c-b7a7-250532132d45">
Story Description
As a Ministry user, I want to be able to edit critical details of a BasicBCeID student's profile and contact info, so that a student's info can remain accurate and up to date. This also allows me to identify the type of login credentials the student has used to log in, which can help me identify where they need to go for login/password issues.
Acceptance Criteria:
Business Context
Note: disability status and SIN update processes do not need to be changed.
Technical
sims.users.identity_provider_type
as bceidboth. Please note thatbceidbasic
andbceidbusiness
are present on DB enum but are not configured.PATCH
"aest/student/:studentId".The text was updated successfully, but these errors were encountered: