Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Release/v1.2.0 to Main #2418

Merged
merged 4 commits into from
Oct 16, 2023
Merged

Merge Release/v1.2.0 to Main #2418

merged 4 commits into from
Oct 16, 2023

Conversation

dheepak-aot
Copy link
Collaborator

Merge Release/v1.2.0 to Main

guru-aot and others added 4 commits October 6, 2023 13:53
- [x] Adjust the 'Edit Program' banner message title to read "Program
Details No Longer Editable"
![image](https://github.com/bcgov/SIMS/assets/62901416/2f5e55ff-082e-4664-8cd0-4e4d785849a2)

- [x] Missing or insecure "X-Content-Type-Options" header
> add_header 'X-Content-Type-Options'  "nosniff";

- [x] Missing "Content-Security-Policy" header
> add_header 'Content-Security-Policy' "default-src 'self'; script-src
'self' 'unsafe-inline'; style-src 'self' 'unsafe-inline'";

- [x] Missing or insecure HTTP Strict-Transport-Security Header
> add_header 'Strict-Transport-Security' "max-age=31536000;
includeSubDomains; preload";

- [x] Missing "Referrer policy" Security Header
> add_header 'Referrer-Policy' "same-origin";

As we are not setting any cookie our application, we are not fixing the
"Cookie with Insecure or Improper or Missing SameSite attribute" issue.
Update institution hyperlinks
 Cherry pick commit from main branch
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.26% ( 2218 / 12853 )
Methods: 7.93% ( 129 / 1626 )
Lines: 20.01% ( 1945 / 9721 )
Branches: 9.56% ( 144 / 1506 )

@dheepak-aot dheepak-aot requested a review from guru-aot October 16, 2023 17:16
@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 46.3% ( 300 / 648 )
Methods: 40% ( 32 / 80 )
Lines: 50.6% ( 251 / 496 )
Branches: 23.61% ( 17 / 72 )

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 75.72% ( 555 / 733 )
Methods: 69.32% ( 61 / 88 )
Lines: 77.64% ( 486 / 626 )
Branches: 42.11% ( 8 / 19 )

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of it, looks good 👍

@dheepak-aot dheepak-aot added Web Portal Form.io Form IO definitions changed. labels Oct 16, 2023
Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@sh16011993 sh16011993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of it @dheepak-aot 👍

Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dheepak-aot dheepak-aot merged commit d1d860e into main Oct 16, 2023
@dheepak-aot dheepak-aot temporarily deployed to DEV October 16, 2023 18:07 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV October 16, 2023 18:10 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV October 16, 2023 18:10 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV October 16, 2023 18:10 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV October 16, 2023 18:10 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV October 16, 2023 18:13 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV October 16, 2023 18:13 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Form.io Form IO definitions changed. Release Branch Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants