Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2376 - Edit Program Banner Message Change #2390

Merged
merged 1 commit into from
Oct 6, 2023
Merged

#2376 - Edit Program Banner Message Change #2390

merged 1 commit into from
Oct 6, 2023

Conversation

guru-aot
Copy link
Collaborator

@guru-aot guru-aot commented Oct 6, 2023 •
edited
Loading

  • Adjust the 'Edit Program' banner message title to read "Program Details No Longer Editable"

@guru-aot guru-aot self-assigned this Oct 6, 2023
@guru-aot guru-aot added Institution Institution Features Web Portal labels Oct 6, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.44% ( 2205 / 12643 )
Methods: 8.1% ( 129 / 1593 )
Lines: 20.18% ( 1932 / 9573 )
Branches: 9.75% ( 144 / 1477 )

sh16011993
sh16011993 approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@sh16011993 sh16011993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 46.73% ( 300 / 642 )
Methods: 40% ( 32 / 80 )
Lines: 51.02% ( 251 / 492 )
Branches: 24.29% ( 17 / 70 )

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 74.93% ( 514 / 686 )
Methods: 67.47% ( 56 / 83 )
Lines: 76.96% ( 451 / 586 )
Branches: 41.18% ( 7 / 17 )

sh16011993
sh16011993 reviewed Oct 6, 2023
View reviewed changes
sources/packages/web/src/views/institution/locations/programs/LocationProgramAddEdit.vue
@@ -11,7 +11,7 @@
<banner
v-if="programData.hasOfferings"
:type="BannerTypes.Success"
header="Students have applied financial aid for this program"
header="Program details no longer editable"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it supposed to be Camelcase? The PR description has it Camelcase.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ticket itself is "Pascal case" but it is not what the UI follows.
@guru-aot can we please have the ticket updated to represent the way that you used it here?
@JasonCTang FYI

andrewsignori-aot
andrewsignori-aot approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ann-aot
ann-aot approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

E2E SIMS API Coverage Report

Totals Coverage
Statements: 54.9% ( 4025 / 7331 )
Methods: 51.89% ( 493 / 950 )
Lines: 59.74% ( 3269 / 5472 )
Branches: 28.93% ( 263 / 909 )

dheepak-aot
dheepak-aot approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 👍

@guru-aot guru-aot merged commit cf32423 into release/v1.2.0 Oct 6, 2023
@guru-aot guru-aot deleted the #2376_Edit_Program_Banner_Message_Changed branch October 6, 2023 19:53
@HRAGANBC
Copy link
Collaborator

Reviewed by SABC Business on Oct 10 - Signed off and looks great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh16011993 sh16011993 sh16011993 approved these changes

@dheepak-aot dheepak-aot dheepak-aot approved these changes

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

@ann-aot ann-aot ann-aot approved these changes

@andrepestana-aot andrepestana-aot Awaiting requested review from andrepestana-aot

@JasonCTang JasonCTang Awaiting requested review from JasonCTang

Assignees

@guru-aot guru-aot

Labels
Institution Institution Features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@guru-aot @HRAGANBC @sh16011993 @dheepak-aot @andrewsignori-aot @ann-aot