Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2376 - Edit Program Banner Message Change #2390

Merged
merged 1 commit into from
Oct 6, 2023
Merged

#2376 - Edit Program Banner Message Change #2390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sources/packages/web/src/views/institution/locations/programs/LocationProgramAddEdit.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<banner
v-if="programData.hasOfferings"
:type="BannerTypes.Success"
header="Students have applied financial aid for this program"
header="Program details no longer editable"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it supposed to be Camelcase? The PR description has it Camelcase.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ticket itself is "Pascal case" but it is not what the UI follows.
@guru-aot can we please have the ticket updated to represent the way that you used it here?
@JasonCTang FYI

summary="This program has study period offerings attached to it, and the program details can no longer be edited. If revisions are required other than to program name or program description, you must create a new program with the correct details."
>
<template #actions>
Expand Down