#1830 - Institution Student Authorization Part 2 #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dheepak-aot
requested review from
andrewsignori-aot,
ann-aot,
sh16011993,
guru-aot,
andrepestana-aot and
JasonCTang
ann-aot
reviewed
May 2, 2023
...ges/backend/apps/api/src/route-controllers/student/_tests_/e2e/student.institutions.utils.ts
Outdated
Show resolved
Hide resolved
ann-aot
reviewed
May 2, 2023
...s/packages/backend/apps/api/src/route-controllers/student/student.institutions.controller.ts
Outdated
Show resolved
Hide resolved
ann-aot
reviewed
May 2, 2023
sources/packages/backend/apps/api/src/services/institution/institution.service.ts
Show resolved
Hide resolved
ann-aot
reviewed
May 2, 2023
ann-aot
reviewed
May 2, 2023
There was a problem hiding this comment.
Good work @dheepak-aot . added some minor comments. I have qn, so, do we have a ticket to add cache to other queries too?
ann-aot
reviewed
May 2, 2023
...ontrollers/student/_tests_/e2e/student.institutions.controller.getStudentProfile.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...student/_tests_/e2e/student.institutions.controller.getStudentApplicationSummary.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...student/_tests_/e2e/student.institutions.controller.getStudentApplicationSummary.e2e-spec.ts
Outdated
Show resolved
Hide resolved
We do not have a ticket for that so far. Probably we can discuss during our upcoming dev sync up and create as we have other things to discuss about the cache to other queries. |
...e-controllers/student/_tests_/e2e/student.institutions.controller.searchStudents.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...e-controllers/student/_tests_/e2e/student.institutions.controller.searchStudents.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...ges/backend/apps/api/src/route-controllers/student/_tests_/e2e/student.institutions.utils.ts
Outdated
Show resolved
Hide resolved
sources/packages/backend/libs/utilities/src/system-configurations-constants.ts
Show resolved
Hide resolved
3 tasks
sources/packages/backend/apps/api/src/auth/guards/institution/institution-bc-public.guard.ts
Outdated
Show resolved
Hide resolved
...ckages/backend/apps/api/src/auth/guards/institution/institution-student-data-access.guard.ts
Outdated
Show resolved
Hide resolved
...ges/backend/apps/api/src/route-controllers/student/_tests_/e2e/student.institutions.utils.ts
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
| @@ -140,3 +140,9 @@ export async function authorizeUserTokenForLocation( | |||
| InstitutionUserTypes.user, | |||
| ); | |||
| } | |||
|
|
|||
| export const INSTITUTION_BC_PUBLIC_ERROR_MESSAGE = | |||
There was a problem hiding this comment.
I am ok to keep those here. I was just having second thoughts if we should move or not to a constant file.
Either way, I would be good with 😉
E2E SIMS API Coverage Report
|
andrewsignori-aot
approved these changes
May 3, 2023
ann-aot
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable Typeorm Cache with Redis
Ref: https://github.com/typeorm/typeorm/blob/master/docs/caching.md