#1792-Enable application details for public institution user #1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_Public_Institution_User
guru-aot
requested review from
andrewsignori-aot,
ann-aot,
sh16011993,
dheepak-aot,
andrepestana-aot and
JasonCTang
ann-aot
reviewed
May 2, 2023
...rs/application/_tests_/application.institutions.controller.getApplicationDetails.e2e-spec.ts
Outdated
Show resolved
Hide resolved
ann-aot
reviewed
May 2, 2023
...rs/application/_tests_/application.institutions.controller.getApplicationDetails.e2e-spec.ts
Outdated
Show resolved
Hide resolved
ann-aot
reviewed
May 2, 2023
...rs/application/_tests_/application.institutions.controller.getApplicationDetails.e2e-spec.ts
Outdated
Show resolved
Hide resolved
ann-aot
reviewed
May 2, 2023
...es/backend/apps/api/src/route-controllers/application/application.institutions.controller.ts
Outdated
Show resolved
Hide resolved
ann-aot
reviewed
May 2, 2023
...es/backend/apps/api/src/route-controllers/application/application.institutions.controller.ts
Outdated
Show resolved
Hide resolved
ann-aot
reviewed
May 2, 2023
ann-aot
reviewed
May 2, 2023
ann-aot
reviewed
May 2, 2023
| name: InstitutionRoutesConst.STUDENT_APPLICATION_DETAILS, | ||
| props: true, | ||
| component: InstitutionApplicationView, | ||
| meta: { |
There was a problem hiding this comment.
I believe we don't need these meta for children if the parent has the same meta
There was a problem hiding this comment.
did u test this scenario @guru-aot . just to confirm
ann-aot
reviewed
May 2, 2023
| @@ -79,15 +79,18 @@ export class ApplicationApi extends HttpBaseClient { | |||
|
|
|||
| /** | |||
| * API Client for application detail. | |||
| * @param applicationId | |||
| * @returns | |||
| * @param applicationId for the application. | |||
dheepak-aot
reviewed
May 3, 2023
| @@ -15,7 +15,7 @@ | |||
| Student Application Details | |||
| {{ | |||
| applicationDetail.applicationNumber | |||
| ? " - " + applicationDetail.applicationNumber | |||
| ? HYPHEN_WITH_SPACE + applicationDetail.applicationNumber | |||
There was a problem hiding this comment.
Will there be an application here without number? We can skip the expression if there is no such possibility.
dheepak-aot
reviewed
May 3, 2023
| Student Application Details | ||
| {{ | ||
| applicationDetail.applicationNumber | ||
| ? HYPHEN_WITH_SPACE + applicationDetail.applicationNumber |
There was a problem hiding this comment.
There was a problem hiding this comment.
removed it and used emptyStringFiller
| @@ -10,6 +10,7 @@ dayjs.extend(customParseFormat); | |||
|
|
|||
| const DEFAULT_EMPTY_VALUE = "-"; | |||
| export const DATE_ONLY_ISO_FORMAT = "YYYY-MM-DD"; | |||
| export const HYPHEN_WITH_SPACE = " - "; | |||
There was a problem hiding this comment.
Please see #1914 (comment)
| }); | ||
| }); | ||
|
|
||
| it("Should not have access to get the student application details if the student submitted and application to non-public institution.", async () => { |
There was a problem hiding this comment.
Minor: we're using "Should/when" in the test cases.
andrewsignori-aot
approved these changes
May 4, 2023
dheepak-aot
approved these changes
May 4, 2023
…_Public_Institution_User
|
Kudos, SonarCloud Quality Gate passed!
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
guru-aot
deleted the
feature/#1792-Enable_Application_Details_For_Public_Institution_User
branch
E2E SIMS API Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable application details page for public institution user
Acceptance Criteria
The sidebar for the application details is added till students, @ann-aot will update the assessments part.
Additional screenshots on the Application details page.
