Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1683 - Show success icon when application is completed #1858

Merged
merged 1 commit into from
Apr 3, 2023
Merged

#1683 - Show success icon when application is completed #1858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ges/backend/apps/api/src/route-controllers/application/application.students.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,6 +545,7 @@ export class ApplicationStudentsController extends BaseController {
const [firstDisbursement, secondDisbursement] = disbursements;
const [scholasticStandingChange] = application.studentScholasticStandings;
return {
applicationStatus: application.applicationStatus,
applicationStatusUpdatedOn: application.applicationStatusUpdatedOn,
pirStatus: application.pirStatus,
firstCOEStatus: firstDisbursement?.coeStatus,
Expand Down
1 change: 1 addition & 0 deletions ...ces/packages/backend/apps/api/src/route-controllers/application/models/application.dto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ export class InProgressApplicationDetailsAPIOutDTO extends IntersectionType(
}

export class ApplicationProgressDetailsAPIOutDTO {
applicationStatus: ApplicationStatus;
applicationStatusUpdatedOn: Date;
pirStatus?: ProgramInfoStatus;
firstCOEStatus?: COEStatus;
Expand Down
7 changes: 4 additions & 3 deletions sources/packages/web/src/components/students/applicationTracker/ApplicationProgressBar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,11 +157,12 @@ export default defineComponent({
applicationProgressDetails.value.appealStatus ===
StudentAppealStatus.Pending
) {
// Application is complete but has warnings.
// Application is completed but has warnings.
statusIconDetails.value = STATUS_ICON_WARNING;
} else if (
// Application is complete.
applicationProgressDetails.value.firstCOEStatus === COEStatus.completed
// Application is completed.
applicationProgressDetails.value.applicationStatus ===
ApplicationStatus.Completed
) {
statusIconDetails.value = STATUS_ICON_SUCCESS;
}
Expand Down
2 changes: 1 addition & 1 deletion ...es/packages/web/src/components/students/applicationTracker/MultipleDisbursementBanner.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ export default defineComponent({
},
coeDenialReason: {
type: String,
required: true,
required: false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did we change this?

Copy link
Collaborator Author

@andrewsignori-aot andrewsignori-aot Apr 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Volar extension got the issue where it was required but it was having a nullable value assigned.

},
firstDisbursementStatus: {
type: String as PropType<DisbursementScheduleStatus>,
Expand Down
1 change: 1 addition & 0 deletions sources/packages/web/src/services/http/dto/Application.dto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ export interface ApplicationSummaryDTO extends ApplicationIdentifiersAPIOutDTO {
}

export interface ApplicationProgressDetailsAPIOutDTO {
applicationStatus: ApplicationStatus;
applicationStatusUpdatedOn: Date;
pirStatus?: ProgramInfoStatus;
firstCOEStatus?: COEStatus;
Expand Down