#1683 - Show success icon when application is completed #1858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Backend Unit Tests Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E SIMS API Coverage Report
|
andrewsignori-aot
requested review from
dheepak-aot,
andrepestana-aot,
sh16011993,
guru-aot,
ann-aot and
JasonCTang
sh16011993
reviewed
Apr 3, 2023
sources/packages/web/src/components/students/applicationTracker/ApplicationProgressBar.vue
Show resolved
Hide resolved
sh16011993
reviewed
Apr 3, 2023
sources/packages/web/src/components/students/applicationTracker/ApplicationProgressBar.vue
Show resolved
Hide resolved
guru-aot
reviewed
Apr 3, 2023
| @@ -156,7 +156,7 @@ export default defineComponent({ | |||
| }, | |||
| coeDenialReason: { | |||
| type: String, | |||
| required: true, | |||
| required: false, | |||
There was a problem hiding this comment.
Volar extension got the issue where it was required but it was having a nullable value assigned.
guru-aot
approved these changes
Apr 3, 2023
There was a problem hiding this comment.
LGTM, just a minor comment for my understanding. Nice work @andrewsignori-aot
andrewsignori-aot
deleted the
fix/#1683-display-icon-completed-reassessment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The success icon was not displayed for a reassessment because the check relied on the COE confirmation.
Change the check to be based on the application status.