-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1683 - Show success icon when application is completed #1858
#1683 - Show success icon when application is completed #1858
Conversation
Kudos, SonarCloud Quality Gate passed!
|
sources/packages/web/src/components/students/applicationTracker/ApplicationProgressBar.vue
Show resolved
Hide resolved
sources/packages/web/src/components/students/applicationTracker/ApplicationProgressBar.vue
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@@ -156,7 +156,7 @@ export default defineComponent({ | |||
}, | |||
coeDenialReason: { | |||
type: String, | |||
required: true, | |||
required: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did we change this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Volar extension got the issue where it was required but it was having a nullable value assigned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a minor comment for my understanding. Nice work @andrewsignori-aot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good. 👍
The success icon was not displayed for a reassessment because the check relied on the COE confirmation.
Change the check to be based on the application status.