Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1683 - Show success icon when application is completed #1858

Merged

Conversation

andrewsignori-aot
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot commented Apr 3, 2023

The success icon was not displayed for a reassessment because the check relied on the COE confirmation.
Change the check to be based on the application status.

image

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@andrewsignori-aot andrewsignori-aot self-assigned this Apr 3, 2023
@andrewsignori-aot andrewsignori-aot added Bug Something isn't working Web Portal Ad-hoc labels Apr 3, 2023
@github-actions
Copy link

github-actions bot commented Apr 3, 2023

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 18.01% ( 1957 / 10865 )
Methods: 8.14% ( 115 / 1413 )
Lines: 20.71% ( 1713 / 8271 )
Branches: 10.92% ( 129 / 1181 )

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 56.72% ( 308 / 543 )
Methods: 46.38% ( 32 / 69 )
Lines: 59.48% ( 276 / 464 )
Branches: 0% ( 0 / 10 )

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 32.41% ( 176 / 543 )
Methods: 21.25% ( 17 / 80 )
Lines: 39.25% ( 157 / 400 )
Branches: 3.17% ( 2 / 63 )

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

E2E SIMS API Coverage Report

Totals Coverage
Statements: 38.07% ( 2565 / 6738 )
Methods: 29.84% ( 262 / 878 )
Lines: 43.65% ( 2194 / 5026 )
Branches: 13.07% ( 109 / 834 )

Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

Copy link
Collaborator

@sh16011993 sh16011993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@@ -156,7 +156,7 @@ export default defineComponent({
},
coeDenialReason: {
type: String,
required: true,
required: false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did we change this?

Copy link
Collaborator Author

@andrewsignori-aot andrewsignori-aot Apr 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Volar extension got the issue where it was required but it was having a nullable value assigned.

Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor comment for my understanding. Nice work @andrewsignori-aot

@andrewsignori-aot andrewsignori-aot merged commit e7d519c into main Apr 3, 2023
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV April 3, 2023 23:47 — with GitHub Actions Inactive
@andrewsignori-aot andrewsignori-aot deleted the fix/#1683-display-icon-completed-reassessment branch April 3, 2023 23:47
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV April 3, 2023 23:47 — with GitHub Actions Inactive
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV April 3, 2023 23:59 — with GitHub Actions Inactive
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ad-hoc Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants