Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1737 - Update institution location content (new) #1839

Merged
merged 4 commits into from
Mar 28, 2023
Merged

#1737 - Update institution location content (new) #1839

merged 4 commits into from
Mar 28, 2023

Conversation

hellolynn-tbtb
Copy link
Contributor

@hellolynn-tbtb hellolynn-tbtb commented Mar 24, 2023 •
edited
Loading

Updates

  • Updated content on location form and summary
  • Added banner on location edit
  • Aligned tooltips styles

Screenshots

Location add/edit

image

Location summary

image

Tooltips

Forms.io tooltips
image

Forms.io tooltips - custom (within content like NOA)
image

Vuetify tooltips
image

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 18.01% ( 1949 / 10824 )
Methods: 8.19% ( 115 / 1404 )
Lines: 20.69% ( 1705 / 8240 )
Branches: 10.93% ( 129 / 1180 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 31.39% ( 167 / 532 )
Methods: 20.51% ( 16 / 78 )
Lines: 38.3% ( 149 / 389 )
Branches: 3.08% ( 2 / 65 )

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 56.72% ( 308 / 543 )
Methods: 46.38% ( 32 / 69 )
Lines: 59.48% ( 276 / 464 )
Branches: 0% ( 0 / 10 )

@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 36.26% ( 2429 / 6699 )
Methods: 27.7% ( 241 / 870 )
Lines: 41.89% ( 2093 / 4997 )
Branches: 11.42% ( 95 / 832 )

@hellolynn-tbtb hellolynn-tbtb marked this pull request as ready for review March 24, 2023 19:49
@hellolynn-tbtb hellolynn-tbtb added User Experience task that relates to UI UX Content Tasks related to UIUX content Web Portal Institution Institution Features labels Mar 24, 2023
@hellolynn-tbtb hellolynn-tbtb mentioned this pull request Mar 24, 2023
Closed
andrewsignori-aot
andrewsignori-aot reviewed Mar 27, 2023
View reviewed changes
sources/packages/web/src/views/institution/EditInstitutionLocation.vue
summary="Please email a request to update the location details. For the primary contact, you can update it without a request."
>
<template #actions>
<v-btn color="info">Email [email protected]</v-btn>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please clarify what is the idea behind this button?
I believe that we are now using it at least in two places para it is actually not doing anything.

Copy link
Contributor Author

@hellolynn-tbtb hellolynn-tbtb Mar 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewsignori-aot The idea of the button on-click is to

  • open an "email client" (e.g. mailto:) AND/OR
  • the user can copy the email address (on their own) OR
  • we can help the user copy the email address like this

Perhaps we can chat about best approach (maybe I can even learn how to do it?). Also I'm open to an adjustment in design if need be. And yes we have it in several places -- profile, programs, offerings (I believe)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarifications, Lynn.
Maybe we can have a clickable link to open the email client and a clipboard icon to copy it to the clipboard.

andrewsignori-aot
andrewsignori-aot reviewed Mar 27, 2023
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good and the tooltips look better across the different areas also. Just a small question, not directly related to this PR.

ann-aot
ann-aot approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

andrewsignori-aot
andrewsignori-aot approved these changes Mar 28, 2023
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hellolynn-tbtb hellolynn-tbtb merged commit 0b7aab5 into main Mar 28, 2023
@hellolynn-tbtb hellolynn-tbtb temporarily deployed to DEV March 28, 2023 21:33 — with GitHub Actions Inactive
@hellolynn-tbtb hellolynn-tbtb deleted the content/institution-location-page-2 branch March 28, 2023 21:33
@hellolynn-tbtb hellolynn-tbtb temporarily deployed to DEV March 28, 2023 21:36 — with GitHub Actions Inactive
@hellolynn-tbtb hellolynn-tbtb temporarily deployed to DEV March 28, 2023 21:51 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

@ann-aot ann-aot ann-aot approved these changes

Assignees
No one assigned
Labels
Content Tasks related to UIUX content Institution Institution Features User Experience task that relates to UI UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hellolynn-tbtb @andrewsignori-aot @ann-aot