Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1737 - Update institution location content #1825

Closed
wants to merge 4 commits into from
Closed

#1737 - Update institution location content #1825

wants to merge 4 commits into from

Conversation

hellolynn-tbtb
Copy link
Contributor

@hellolynn-tbtb hellolynn-tbtb commented Mar 21, 2023 •
edited
Loading

OLD ONE - New one #1839

Updates

  • Updated content on location form and summary
  • Added banner on location edit
  • Aligned tooltips styles

Additional

  • Noticed there was unknown changes in the last commit (assessment.ts stuff?) wasn't showing in VisualStudios but showed up in GitHub

Screenshots

Location add/edit

image

Location summary

image

Tooltips

Forms.io tooltips
image

Forms.io tooltips - custom (within content like NOA)
image

Vuetify tooltips
image

@hellolynn-tbtb hellolynn-tbtb self-assigned this Mar 21, 2023
@hellolynn-tbtb hellolynn-tbtb linked an issue Mar 21, 2023 that may be closed by this pull request
DEV UI Content - Manage locations #1737
Closed
4 tasks
@hellolynn-tbtb hellolynn-tbtb marked this pull request as ready for review March 23, 2023 22:17
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.87% ( 1931 / 10806 )
Methods: 8.13% ( 114 / 1403 )
Lines: 20.55% ( 1690 / 8225 )
Branches: 10.78% ( 127 / 1178 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 30.87% ( 163 / 528 )
Methods: 20.51% ( 16 / 78 )
Lines: 37.66% ( 145 / 385 )
Branches: 3.08% ( 2 / 65 )

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 56.72% ( 308 / 543 )
Methods: 46.38% ( 32 / 69 )
Lines: 59.48% ( 276 / 464 )
Branches: 0% ( 0 / 10 )

@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 36.26% ( 2429 / 6699 )
Methods: 27.7% ( 241 / 870 )
Lines: 41.89% ( 2093 / 4997 )
Branches: 11.42% ( 95 / 832 )

@hellolynn-tbtb hellolynn-tbtb requested review from andrewsignori-aot and ann-aot and removed request for andrewsignori-aot and ann-aot March 23, 2023 23:24
@hellolynn-tbtb
Copy link
Contributor Author

OLD ONE - New PR #1839

@hellolynn-tbtb hellolynn-tbtb deleted the content/instituion-location-page branch March 28, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hellolynn-tbtb hellolynn-tbtb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DEV UI Content - Manage locations
1 participant
@hellolynn-tbtb