Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIMS to SFAS Bridge - Legacy Restrictions #4101

Closed
4 of 6 tasks
CarlyCotton opened this issue Dec 13, 2024 · 1 comment
Closed
4 of 6 tasks

SIMS to SFAS Bridge - Legacy Restrictions #4101

CarlyCotton opened this issue Dec 13, 2024 · 1 comment
Assignees
@andrepestana-aot @CarlyCotton
Milestone
Post Part-Time Pr...

Comments

@CarlyCotton
Copy link
Collaborator

CarlyCotton commented Dec 13, 2024 •
edited by andrepestana-aot
Loading

User Story
In the file layout for our SIMS to SFAS Bridge we have allocated 4 characters for the restriction code. With the change in functionality to legacy restrictions, we have created LGCY_ restriction codes that are longer than 4 characters. As an internal integration partner, I need the layout on the flat file to be consistent and any newly created LGCY_AA restriction is being sent and throwing off the layout for restriction records.

Acceptance Criteria

  • Do not send any isLegacy = true restrictions in the SIMS to SFAS Bridge file
  • Update restricion field in bridge file with restriction code to allow 10 characters
  • Ensure the bridge file is created with the record fields limited to the length as stated in the File Layout
  • Add filler as needed to bring to 10 characters

Additional Context
Carly will update bridge layout doc and send to legacy team
Example of >4 characters
image.png
image.png

Technical

  • Add the filter to the existing query.
  • Create or adapt an existing E2E to test the isLegacy filter.
@CarlyCotton CarlyCotton added the Business Items under Business Consideration label Dec 13, 2024
@CarlyCotton CarlyCotton self-assigned this Dec 13, 2024
@Joshua-Lakusta Joshua-Lakusta added Dev & Architecture Development and Architecture and removed Business Items under Business Consideration labels Dec 17, 2024
@Joshua-Lakusta
Copy link
Collaborator

2.3 release assuming 2.2 has been pushed to stage

@andrewsignori-aot andrewsignori-aot removed the Dev & Architecture Development and Architecture label Dec 17, 2024
@andrepestana-aot andrepestana-aot self-assigned this Dec 18, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 20, 2024
@andrepestana-aot
#4101 - SIMS to SFAS Bridge - Legacy Restrictions (#4158)
658c753 
- Filtered legacy restrictions that are going to be sent to SFAS;
- Formatted restriction field to have a minimum of 10 characters in the
file;
- Added a legacy restriction to the e2e test.

![image](https://github.com/user-attachments/assets/550ecb08-2d43-4823-b999-ac991ca87ab0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrepestana-aot andrepestana-aot

@CarlyCotton CarlyCotton

Labels
None yet
Projects
None yet
Milestone
Post Part-Time Primera Importante Mucho
Development

No branches or pull requests
5 participants
@andrewsignori-aot @andrepestana-aot @Joshua-Lakusta @CarlyCotton @AnnaPBashkatova