#4101 - SIMS to SFAS Bridge - Legacy Restrictions #4158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
andrepestana-aot
commented
Dec 19, 2024
•
andrepestana-aot
commented
- Filtered legacy restrictions that are going to be sent to SFAS;
- Formatted restriction field to have a minimum of 10 characters in the file;
- Added a legacy restriction to the e2e test.
dheepak-aot
reviewed
Dec 20, 2024
...nd/libs/integrations/src/sfas-integration/sims-sfas-files/sims-to-sfas-restriction-record.ts
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Dec 20, 2024
| @@ -824,7 +844,10 @@ describe(describeProcessorRootTest(QueueNames.SIMSToSFASIntegration), () => { | |||
| : " "; | |||
| return `400${studentId.toString().padStart(10, "0")}${studentRestriction.id | |||
| .toString() | |||
| .padStart(10, "0")}${restriction.restrictionCode}${formatDate( | |||
| .padStart(10, "0")}${restriction.restrictionCode.padEnd( | |||
dheepak-aot
reviewed
Dec 20, 2024
| application, | ||
| restriction: legacyRestriction, | ||
| }); | ||
|
|
There was a problem hiding this comment.
Please set the updated date of legacy restriction to fall under the delta period using simsDataUpdatedDate
// Student has a legacy restriction that should be ignored.
const legacyStudentRestriction = await saveFakeStudentRestriction(
db.dataSource,
{
student,
application,
restriction: legacyRestriction,
},
);
await db.studentRestriction.update(
{
id: legacyStudentRestriction.id,
},
{
updatedAt: simsDataUpdatedDate,
},
);There was a problem hiding this comment.
My bad. I didn't see that it was set in the save.
But also please use the factory to create restriction createFakeRestriction instead of saving it directly.
guru-aot
reviewed
Dec 20, 2024
| @@ -234,6 +234,7 @@ export class SIMSToSFASService { | |||
| where: { | |||
| restriction: { | |||
| restrictionType: RestrictionType.Provincial, | |||
| isLegacy: false, | |||
guru-aot
reviewed
Dec 20, 2024
| @@ -35,7 +35,7 @@ export class SIMSToSFASRestrictionRecord extends SIMSToSFASBaseRecord { | |||
| record.append(this.recordTypeCode); | |||
| record.appendNumberWithFiller(this.studentId, 10); | |||
| record.appendNumberWithFiller(this.restrictionId, 10); | |||
| record.append(this.restrictionCode); | |||
| record.appendStringWithFiller(this.restrictionCode, 10); | |||
guru-aot
approved these changes
Dec 20, 2024
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
dheepak-aot
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Thanks for making the changes . Looks good @andrepestana-aot .👍
andrepestana-aot
deleted the
4104_sims_to_sfas_bridge_legacy_restrictions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.