Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix: Change file naming convention of the SIN validation request file #3832

Closed
2 of 4 tasks
JasonCTang opened this issue Oct 24, 2024 · 0 comments
Closed
2 of 4 tasks

Hotfix: Change file naming convention of the SIN validation request file #3832

JasonCTang opened this issue Oct 24, 2024 · 0 comments
Assignees
@bidyashish @JasonCTang
Labels
Integration
Milestone
Post Part-Time Pr...

Comments

@JasonCTang
Copy link
Collaborator

JasonCTang commented Oct 24, 2024 •
edited by ninosamson
Loading

Unlike other files, there is no difference in the SIN validation request file. Currently the file name being generated per environment are:
DEV: DBC####.OS (I'm actually just guessing that this one starts with a D, as I wasn't able to generate a file in DEV)
TEST: TBC####.OS
PROD: PBC####.OS

The expected file name is just BC####.OS in all environments.

  • Do not use value from environment variable ESDC_ENVIRONMENT_CODE.
  • No changes needed to response file handling.

Need to fix Invalid header format 0010000000120241023BC. There’s 8 characters, but should be 6 characters only.
@ninosamson ninosamson added Business Items under Business Consideration Dev & Architecture Development and Architecture and removed Business Items under Business Consideration labels Oct 24, 2024
@andrewsignori-aot andrewsignori-aot removed the Dev & Architecture Development and Architecture label Oct 24, 2024
@ninosamson ninosamson changed the title Change file naming convention of the SIN validation request file Hotfix: Change file naming convention of the SIN validation request file Oct 30, 2024
@bidyashish bidyashish self-assigned this Oct 31, 2024
bidyashish added a commit that referenced this issue Oct 31, 2024
@bidyashish
#3832 - Hotfix: Change file naming convention of the SIN validation r…
32feef5 
…equest file (#3864)

**AC*
The expected file name is just BC####.OS in all environments. 

- [x] Do not use value from environment variable
`ESDC_ENVIRONMENT_CODE`.
- [x] No changes needed to response file handling.

Need to fix Invalid header format 0010000000120241023BC. There’s 8
characters, but should be 6 characters only.

- [x]  Update batch number to "6" from "8"

https://github.com/bcgov/SIMS/blob/main/sources/packages/backend/libs/integrations/src/esdc-integration/sin-validation/sin-validation-files/sin-validation-file-header.ts#L38
- [x]  Fix e2e tests

*Note:
No E2E file changed [PCSLP.PBC.BC0000.ISR
](https://github.com/bcgov/SIMS/blob/8faa4e583c4d0ce8a657be52e9965bd2ed8c3caa/sources/packages/backend/apps/queue-consumers/src/processors/schedulers/esdc-integration/sin-validation-integration/_tests_/sin-receive-files/PCSLP.PBC.BC0000.ISR)
Current E2E test has correct header format `00100500220220921BC1 ` -> 20
Character
 Sample Invalid header `0010000000120241023BC`  -> 22 Character
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bidyashish bidyashish

@JasonCTang JasonCTang

Labels
Integration
Projects
None yet
Milestone
Post Part-Time Primera Importante Mucho
Development

No branches or pull requests
5 participants
@bidyashish @ninosamson @andrewsignori-aot @JasonCTang @michesmith