#3832 - Hotfix: Change file naming convention of the SIN validation request file #3864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidyashish
added
Hotfix
|
I'd also add the additional AC on this one for batch number @bidyashish |
|
The batch number update is missing in the PR. Please take care.
|
bidyashish
changed the title
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
dheepak-aot
reviewed
Oct 31, 2024
| @@ -35,7 +35,7 @@ export class SINValidationFileHeader implements FixedFormatFileLine { | |||
| getFixedFormat(): string { | |||
| const record = new StringBuilder(); | |||
| record.append(this.recordTypeCode); | |||
| record.appendWithStartFiller(this.batchNumber, 8, NUMBER_FILLER); | |||
| record.appendWithStartFiller(this.batchNumber, 6, NUMBER_FILLER); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*AC
The expected file name is just BC####.OS in all environments.
ESDC_ENVIRONMENT_CODE.Need to fix Invalid header format 0010000000120241023BC. There’s 8 characters, but should be 6 characters only.
https://github.com/bcgov/SIMS/blob/main/sources/packages/backend/libs/integrations/src/esdc-integration/sin-validation/sin-validation-files/sin-validation-file-header.ts#L38
*Note:
No E2E file changed PCSLP.PBC.BC0000.ISR
Current E2E test has correct header format
00100500220220921BC1-> 20 CharacterSample Invalid header
0010000000120241023BC-> 22 Character