Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG - Content displayed twice #3812

Closed
6 tasks
CarlyCotton opened this issue Oct 21, 2024 · 0 comments
Closed
6 tasks

BUG - Content displayed twice #3812

CarlyCotton opened this issue Oct 21, 2024 · 0 comments
Assignees
@andrepestana-aot @CarlyCotton
Labels
Bug Something isn't working Student Student Features
Milestone
Post Part-Time Pr...

Comments

@CarlyCotton
Copy link
Collaborator

CarlyCotton commented Oct 21, 2024 •
edited by andrewsignori-aot
Loading

Description
Post upgrades there are a few odd content items that have been noticed. They used to show just once and now the content is duplicated.

Acceptance Criteria

  • Correct the content display to show it only once:
    • Welcome page of application
    • File Uploaders (Looks like every one is duplicating the content)

Screenshots
image.png

image.png

image.png

Technical

  • Possible solution to add the HTML Element Tag as div as shown below.
    • Investigate the root cause further.
  • Check all HTML Element inside the Student Application.

image.png
@CarlyCotton CarlyCotton added the Business Items under Business Consideration label Oct 21, 2024
@CarlyCotton CarlyCotton self-assigned this Oct 21, 2024
@ninosamson ninosamson added the Bug Something isn't working label Oct 22, 2024
@Joshua-Lakusta Joshua-Lakusta added Dev & Architecture Development and Architecture and removed Business Items under Business Consideration labels Oct 22, 2024
@andrewsignori-aot andrewsignori-aot removed the Dev & Architecture Development and Architecture label Oct 22, 2024
@andrepestana-aot andrepestana-aot self-assigned this Oct 23, 2024
github-merge-queue bot pushed a commit that referenced this issue Oct 24, 2024
@andrepestana-aot
#3812 - BUG - Content displayed twice (#3828)
827755c 
The issue happened because the markup in the HTML component is invalid.
The "p" tag could not be used with children elements like: address,
article, aside, blockquote, details, dialog, div, dl, fieldset,
figcaption, figure, footer, form, h1, h2, h3, h4, h5, h6, header,
hgroup, hr, main, menu, nav, ol, p, pre, search, section, table, or ul.

Form.io changed its default parent tag from p to div:
formio/formio.js#5792

Similar issue and developer explanation/recommendation:
formio/formio.js#5598 (comment)

Found some other issues not reported in the ticket as this one:

![image](https://github.com/user-attachments/assets/9ce4b90e-605b-48f9-9f8d-b73f220f2f4d)

- Checked all form.io forms;
- Changed the "p" tag to "div" when the component had invalid children
tags for paragraph;
- Changed some other invalid HTML found when doing the check.
@michesmith michesmith added the Student Student Features label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrepestana-aot andrepestana-aot

@CarlyCotton CarlyCotton

Labels
Bug Something isn't working Student Student Features
Projects
None yet
Milestone
Post Part-Time Primera Importante Mucho
Development

No branches or pull requests
6 participants
@ninosamson @andrewsignori-aot @andrepestana-aot @Joshua-Lakusta @CarlyCotton @michesmith