#3812 - BUG - Content displayed twice #3828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -357,7 +357,7 @@ | |||
| "properties": {}, | |||
| "allowMultipleMasks": false, | |||
| "addons": [], | |||
| "tag": "p", | |||
| "tag": "li", | |||
There was a problem hiding this comment.
This one didn't have any issue with the rendering but I changed to make it a valid HTML.
lewischen-aot
approved these changes
Oct 24, 2024
andrewsignori-aot
approved these changes
Oct 24, 2024
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue happened because the markup in the HTML component is invalid. The "p" tag could not be used with children elements like: address, article, aside, blockquote, details, dialog, div, dl, fieldset, figcaption, figure, footer, form, h1, h2, h3, h4, h5, h6, header, hgroup, hr, main, menu, nav, ol, p, pre, search, section, table, or ul.
Form.io changed its default parent tag from p to div: formio/formio.js#5792
Similar issue and developer explanation/recommendation: formio/formio.js#5598 (comment)
Found some other issues not reported in the ticket as this one:
