-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partner Current year income application question #3615
Comments
Joshua-Lakusta
added
Business
Items under Business Consideration
Student
Student Features
User Story
labels
Aug 7, 2024
ninosamson
changed the title
Partner Current year income application question
[NEEDS ATTENTION] Partner Current year income application question
Aug 27, 2024
Joshua-Lakusta
changed the title
[NEEDS ATTENTION] Partner Current year income application question
Partner Current year income application question
Oct 8, 2024
JerPearson
added
Dev & Architecture
Development and Architecture
and removed
Business
Items under Business Consideration
labels
Oct 15, 2024
Updated AC's around the UI after discussion with Dheepak |
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 13, 2024
# Student Application - Partner current year income ## Student application form update - [x] The form input `IsYourPartnerAbleToReport` which was coming from BCSC question is now converted to a form.io calculated variable which returns `true | false` instead of `"yes" | "no"`. - [x] Added a question to enable the current year partner income submission in the partner information panel. The question blurb consists of the `dynamic current year` ![image](https://github.com/user-attachments/assets/7e1c74f4-1958-4e8f-8381-1146e2a63e3d) - [x] The info and warning banners are delayed until both BCSC and Current year income questions are answered. ![image](https://github.com/user-attachments/assets/9b5a30da-ea26-467d-ac17-38df278785d2) - [x] When the question for current year income is answered as `Yes` show the current year income question with options and file upload instead of current tax return income. ![image](https://github.com/user-attachments/assets/8d178cfb-f1a3-46b4-8684-d77615599448) - [x] When student enters the current year income for the partner instead of the current tax return income, then choose the self declaration path with exception instead of supporting user input even if the partner is eligible for BC Services Card. ![image](https://github.com/user-attachments/assets/9d8f3636-dc94-4681-9186-79e0081d5a99) ![image](https://github.com/user-attachments/assets/c1a9f449-0013-4311-9cee-891ffa19ac1b) ![image](https://github.com/user-attachments/assets/cc08d1fa-c073-4ddb-987e-df7fc23d066d) ![image](https://github.com/user-attachments/assets/f1f688f2-b541-4c1b-a4ae-ed72d7001e4c) ![image](https://github.com/user-attachments/assets/67711182-4e3c-43d2-ad8a-463eff5df067) ## Content Updates - [x] The content (header and the blurb) updated for the previously called `Partner Income` section. ![image](https://github.com/user-attachments/assets/7ac2bc9d-30b4-4b98-8bb6-d7d1599927c8) ## Assessment gateway updates - [x] Minor update to `assessment-gateway` and `fulltime-assessment-*` to use the input `IsYourPartnerAbleToReport` to evaluate `true | false` instead of `"yes" | "no"` ## Workflow E2E test updates - [x] Changed the data type of `studentDataIsYourPartnerAbleToReport` to boolean from YesNo. ## Upcoming PR - `part-time-assessment-*` changes - Workflow E2E tests.
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 14, 2024
…ts (#3934) ## Partner current year income - Assessment workflow - [x] Updated the `load-assessment-consolidated-data` to return `studentDataCurrentYearPartnerIncome` based on the student input from formio. - [x] In `parttime-assessment-*.bpmn` updated the application data path of `partner information and income` to set `calculatedDataCurrentYearPartnerIncome` based on student input from formio. ![image](https://github.com/user-attachments/assets/ad9156e0-186f-4263-a742-0f106c3147ad) ## E2E Tests - [x] Added E2E tests for following scenarios. 1. Partner reporting their tax return income and no current year income was reported. 2. Student reporting partner's current year income through the new self reporting path. 3. Student reporting partner's tax return income through the existing self reporting path. ![image](https://github.com/user-attachments/assets/29e520f4-93aa-40cc-83fa-998b2f816545) ## New Test Suite - New test suite is added to the `costs` section in the `parttime-assessment` of E2E tests. This was done considering that the tests under `costs` are expected to validate the costs/expenses/other inputs like income which are the major inputs towards the awards calculation. Please suggest if the test suite doesn't fit under `costs`. ![image](https://github.com/user-attachments/assets/da1217f7-5cc3-40ca-b617-b50481158f5f)
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 14, 2024
**Updated the blurb for self-declare partner financial information.** ![image](https://github.com/user-attachments/assets/53fa5453-7818-4a55-aeca-d6f412f350a5)
@Joshua-Lakusta as discussed, if a FT application is submitted with student having a partner and student reporting partner's current year income, then this specific scenario breaks the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As a student I want to be able to submit my application with my partners current year income through an exception path question. The question needs to be post the BCSC question but modify the outcomes as sub question. This is important so that students can receive their correct assessment.
This is linked to the change request built in ticket #3620
Acceptance Criteria
Application Changes
New partner BCSC question process
Replace "YEAR" with dynamic calculation YEAR = first year in program year (2023-2024 would be 2023)
2 radio option outcomes for this question as yes or no
If the answer is no then follow previous processes partner portal banner if they selected yes to BCSC or self declare path if the stated no to BCSC
If they answer "yes" to the new question it should take them to a new self declare path that has the estimated current year income question replacing the normal income field question.
Answering yes will hide the tax return income input
The banners attached to the BCSC question must be delayed until both questions have been completed and the path forward is decided.
See image for baseline logic for pathing not for use in work flows just showing the logic
Modified self declare path
Replace "YEAR" with dynamic calculation YEAR = first year in program year (2023-2024 would be 2023)
Add income entry field that will represent a new value to be created and named by dev doing the ticket (partnerestimatedincome)
Income field should follow the same rules as the estimated student income version
Heading above the income entry field should state: point Add missing compliance audit file #4
Content:
Calculation Updates
Update calculations
Current
Ministry exception update
Technical
assessment-gateway
to prevent supporting user creation, as shown in the below image. Adjust the label to reflect the most recent logic.- [x] Exception creation is handled dynamically. Ask for help if you have never done it before. - [x] No `fulltime-assessment-*` workflow changes are expected now. - [x] Workflow E2E tests.
The text was updated successfully, but these errors were encountered: