Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3615 - Partner current year income path - Part 1 #3918

Merged
merged 5 commits into from
Nov 13, 2024

Conversation

dheepak-aot
Copy link
Collaborator

@dheepak-aot dheepak-aot commented Nov 8, 2024

Student Application - Partner current year income

Student application form update

  • The form input IsYourPartnerAbleToReport which was coming from BCSC question is now converted to a form.io calculated variable which returns true | false instead of "yes" | "no".

  • Added a question to enable the current year partner income submission in the partner information panel. The question blurb consists of the dynamic current year

image

  • The info and warning banners are delayed until both BCSC and Current year income questions are answered.

image

  • When the question for current year income is answered as Yes show the current year income question with options and file upload instead of current tax return income.

image

  • When student enters the current year income for the partner instead of the current tax return income, then choose the self declaration path with exception instead of supporting user input even if the partner is eligible for BC Services Card.

image

image

image

image

image

Content Updates

  • The content (header and the blurb) updated for the previously called Partner Income section.
    image

Assessment gateway updates

  • Minor update to assessment-gateway and fulltime-assessment-* to use the input IsYourPartnerAbleToReport to evaluate true | false instead of "yes" | "no"

Workflow E2E test updates

  • Changed the data type of studentDataIsYourPartnerAbleToReport to boolean from YesNo.

Upcoming PR

  • part-time-assessment-* changes
  • Workflow E2E tests.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@dheepak-aot dheepak-aot self-assigned this Nov 8, 2024
@dheepak-aot dheepak-aot marked this pull request as ready for review November 9, 2024 00:13
@andrewsignori-aot andrewsignori-aot added Form.io Form IO definitions changed. Camunda Worflow Involves camunda workflow changes labels Nov 12, 2024
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<bpmn:definitions xmlns:bpmn="http://www.omg.org/spec/BPMN/20100524/MODEL" xmlns:bpmndi="http://www.omg.org/spec/BPMN/20100524/DI" xmlns:dc="http://www.omg.org/spec/DD/20100524/DC" xmlns:di="http://www.omg.org/spec/DD/20100524/DI" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:zeebe="http://camunda.org/schema/zeebe/1.0" xmlns:bioc="http://bpmn.io/schema/bpmn/biocolor/1.0" xmlns:color="http://www.omg.org/spec/BPMN/non-normative/color/1.0" xmlns:modeler="http://camunda.org/schema/modeler/1.0" xmlns:camunda="http://camunda.org/schema/1.0/bpmn" id="Definitions_0ihicdz" targetNamespace="http://bpmn.io/schema/bpmn" exporter="Camunda Modeler" exporterVersion="5.27.0" modeler:executionPlatform="Camunda Cloud" modeler:executionPlatformVersion="8.4.0" camunda:diagramRelationId="7a75e87a-6774-4e60-9a94-5dbbe3be143a">
<bpmn:definitions xmlns:bpmn="http://www.omg.org/spec/BPMN/20100524/MODEL" xmlns:bpmndi="http://www.omg.org/spec/BPMN/20100524/DI" xmlns:dc="http://www.omg.org/spec/DD/20100524/DC" xmlns:di="http://www.omg.org/spec/DD/20100524/DI" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:zeebe="http://camunda.org/schema/zeebe/1.0" xmlns:bioc="http://bpmn.io/schema/bpmn/biocolor/1.0" xmlns:color="http://www.omg.org/spec/BPMN/non-normative/color/1.0" xmlns:modeler="http://camunda.org/schema/modeler/1.0" xmlns:camunda="http://camunda.org/schema/1.0/bpmn" id="Definitions_0ihicdz" targetNamespace="http://bpmn.io/schema/bpmn" exporter="Camunda Modeler" exporterVersion="5.28.0" modeler:executionPlatform="Camunda Cloud" modeler:executionPlatformVersion="8.4.0" camunda:diagramRelationId="7a75e87a-6774-4e60-9a94-5dbbe3be143a">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

"components": [
{
"key": "currentYearPartnerIncomeApplicationExceptionCurrentYearPartnerIncome",
"label": "Current Year Partner Income",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the last two exceptions in this list seem to be using a different case.
This one should be Current year partner's income probably.
Not a blocker if it is following business requirements.

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed the content from AC. Updated it.
image

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, looks good 👍

Copy link
Collaborator

@bidyashish bidyashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Thanks for clarification!

Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.3% ( 3709 / 16632 )
Methods: 10.38% ( 214 / 2062 )
Lines: 25.64% ( 3217 / 12545 )
Branches: 13.73% ( 278 / 2025 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 86.92% ( 1243 / 1430 )
Methods: 88.57% ( 124 / 140 )
Lines: 87.77% ( 1055 / 1202 )
Branches: 72.73% ( 64 / 88 )

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 66.46% ( 5644 / 8492 )
Methods: 63.93% ( 693 / 1084 )
Lines: 70.48% ( 4446 / 6308 )
Branches: 45.91% ( 505 / 1100 )

@dheepak-aot dheepak-aot added this pull request to the merge queue Nov 13, 2024
Merged via the queue into main with commit 7105ad7 Nov 13, 2024
20 checks passed
@dheepak-aot dheepak-aot deleted the feature/#3615-partner-current-year-income branch November 15, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Camunda Worflow Involves camunda workflow changes Form.io Form IO definitions changed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants