Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - unexpected error for SIN change and manual validation screen when you try to submit #3596

Closed
Joshua-Lakusta opened this issue Jul 31, 2024 · 1 comment
Closed

Bug - unexpected error for SIN change and manual validation screen when you try to submit #3596

Joshua-Lakusta opened this issue Jul 31, 2024 · 1 comment
Assignees
@dheepak-aot @Joshua-Lakusta
Labels
Bug Something isn't working
Milestone
Post Part-Time Pr...

Comments

@Joshua-Lakusta
Copy link
Collaborator

Joshua-Lakusta commented Jul 31, 2024 •
edited
Loading

Describe the Bug
Some SIN numbers are triggering an unexpected error when we attempt to manually add them in the ministry portal.

Expected Behaviour
Be able to add the SIN with no errors

Actual Behaviour
What actually happened is that the system kicked back a unexpected error message in the top right

** Steps To Reproduce**
Steps to reproduce the behaviour:

  1. Go to ministry portal
  2. Search and access a student account
  3. manually try to change the SIN with out overriding the sin validation. SIN is previously over ridden
  4. Use any SIN
  5. add note
  6. submit

image.png

image.png

New photo as of 2024-10-22
image.png
@Joshua-Lakusta Joshua-Lakusta added Bug Something isn't working Business Items under Business Consideration labels Jul 31, 2024
@Joshua-Lakusta Joshua-Lakusta changed the title Bug - unexpected error for SIN validation screen when you try to submit Bug - unexpected error for SIN change and manual validation screen when you try to submit Jul 31, 2024
@CarlyCotton CarlyCotton added Dev & Architecture Development and Architecture and removed Business Items under Business Consideration labels Aug 1, 2024
@andrewsignori-aot andrewsignori-aot removed the Dev & Architecture Development and Architecture label Dec 10, 2024
@dheepak-aot dheepak-aot self-assigned this Dec 27, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 31, 2024
@dheepak-aot
#3596 - Bug on ministry add new SIN to student (#4191)
17c26c9 
## Issue

The optional checkbox to `Skip the validations` returns `undefined`
(When not touched) and `null` (on form reset) which is considered as bad
request as the API is expecting a boolean value for `skipValidations`.

## Solution

- [x] Initialize the form-model with `skipValidations` as `false`.
- [x] On the event of model value being updated, convert the input value
to boolean using the event `update:model-value`.

## Minor Refactor

- [x] Removed the call to `resetValidation()` as it has no impact after
`reset()` is called.


![image](https://github.com/user-attachments/assets/d17fd370-0d7f-478d-99e4-728495be3cff)
@CarlyCotton
Copy link
Collaborator

Reviewed on 2024-12-31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dheepak-aot dheepak-aot

@Joshua-Lakusta Joshua-Lakusta

Labels
Bug Something isn't working
Projects
None yet
Milestone
Post Part-Time Primera Importante Mucho
Development

No branches or pull requests
4 participants
@dheepak-aot @andrewsignori-aot @Joshua-Lakusta @CarlyCotton