#3596 - Bug on ministry add new SIN to student

[dheepak-aot]

Issue

The optional checkbox to Skip the validations returns undefined (When not touched) and null (on form reset) which is considered as bad request as the API is expecting a boolean value for skipValidations.

Solution

• Initialize the form-model with skipValidations as false.
• On the event of model value being updated, convert the input value to boolean using the event update:model-value.

Minor Refactor

• Removed the call to resetValidation() as it has no impact after reset() is called.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Backend Unit Tests Coverage Report

Totals
Statements:	22.2% ( 3783 / 17038 )
Methods:	10.19% ( 219 / 2150 )
Lines:	25.65% ( 3278 / 12781 )
Branches:	13.57% ( 286 / 2107 )

[github-actions]

E2E Workflow Workers Coverage Report

Totals
Statements:	65.59% ( 589 / 898 )
Methods:	59.63% ( 65 / 109 )
Lines:	68.72% ( 468 / 681 )
Branches:	51.85% ( 56 / 108 )

[github-actions]

E2E Queue Consumers Coverage Report

Totals
Statements:	86.14% ( 1249 / 1450 )
Methods:	82.42% ( 136 / 165 )
Lines:	88.51% ( 1032 / 1166 )
Branches:	68.07% ( 81 / 119 )

[github-actions]

E2E SIMS API Coverage Report

Totals
Statements:	67.4% ( 5922 / 8787 )
Methods:	65.09% ( 729 / 1120 )
Lines:	71.33% ( 4647 / 6515 )
Branches:	47.4% ( 546 / 1152 )

[bidyashish]

Looks Good!

Vscode ESlint giving error

Update: Resolved

[guru-aot]

LGTM, nice work @dheepak-aot