Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the Maximum Offering Name Character Limit to 100 Characters #3393

Closed
6 tasks
HRAGANBC opened this issue Jun 7, 2024 · 0 comments
Closed
6 tasks
Assignees
Labels
Institution Institution Features

Comments

@HRAGANBC
Copy link
Collaborator

HRAGANBC commented Jun 7, 2024

We want to expand the overall offering name character limit, while:

  • Increase the max characters for an offering to 100.
  • Accomodate the new 100 character limit in instances where Offering Name is referenced, including:
    • Institution performing COE
    • Student NoA
    • Institution Reporting Scholastic Standing
    • Institution Completing PIR
    • Student Application Dropdown Menu

Additional context:
50 characters was found to be too few.

Technical

  • Change the form.io client-side validation.
  • Change the education-program-offering.model.ts constant OFFERING_NAME_MAX_LENGTH.
  • No DB changes expected.
  • Check the above-mentioned UIs to ensure the 100-character offering names will be accommodated in the UI. Feel free to paste some screenshots to the ticket to allow the business to review it.
@HRAGANBC HRAGANBC added the Business Items under Business Consideration label Jun 7, 2024
@HRAGANBC HRAGANBC added Dev & Architecture Development and Architecture and removed Business Items under Business Consideration labels Jul 4, 2024
@andrewsignori-aot andrewsignori-aot removed the Dev & Architecture Development and Architecture label Aug 1, 2024
@CarlyCotton CarlyCotton added the Institution Institution Features label Sep 10, 2024
@CarlyCotton CarlyCotton self-assigned this Sep 10, 2024
@bidyashish bidyashish self-assigned this Oct 16, 2024
github-merge-queue bot pushed a commit that referenced this issue Oct 22, 2024
…racters (#3800)

**Technical**
- [x] Change the form.io client-side validation.
- [x] Change the
[education-program-offering.model.ts](https://github.com/bcgov/SIMS/blob/e5b7ea01bf15f36271a9dae005a5e93b8998da7b/sources/packages/backend/libs/sims-db/src/entities/education-program-offering.model.ts#L20)
constant `OFFERING_NAME_MAX_LENGTH`.
- [x] No DB changes expected.
- [x] Check the above-mentioned UIs to ensure the 100-character offering
names will be accommodated in the UI. Feel free to paste some
screenshots to the ticket to allow the business to review it.

Error Over 100 Character 

![image](https://github.com/user-attachments/assets/eb023c0f-775b-4dc3-80e0-9d20c8869b6b)


Instituition Page:

![image](https://github.com/user-attachments/assets/b77feb19-a2a6-45f7-b9e3-105e5d489c9b)

Drop Down Section:

![image](https://github.com/user-attachments/assets/13f984ad-d180-44c7-b370-0d8df3766a31)

Offering Page:

![image](https://github.com/user-attachments/assets/40b74aa9-f317-43a9-918c-69944e6bd12a)

Add Offering:

![image](https://github.com/user-attachments/assets/3c6510dc-da8d-4345-9cf0-2ad558796f23)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Institution Institution Features
Projects
None yet
Development

No branches or pull requests

6 participants