Skip to content

Commit

Permalink
#3393 - Increase the Maximum Offering Name Character Limit to 100 Cha…
Browse files Browse the repository at this point in the history
…racters (#3800)

**Technical**
- [x] Change the form.io client-side validation.
- [x] Change the
[education-program-offering.model.ts](https://github.com/bcgov/SIMS/blob/e5b7ea01bf15f36271a9dae005a5e93b8998da7b/sources/packages/backend/libs/sims-db/src/entities/education-program-offering.model.ts#L20)
constant `OFFERING_NAME_MAX_LENGTH`.
- [x] No DB changes expected.
- [x] Check the above-mentioned UIs to ensure the 100-character offering
names will be accommodated in the UI. Feel free to paste some
screenshots to the ticket to allow the business to review it.

Error Over 100 Character 

![image](https://github.com/user-attachments/assets/eb023c0f-775b-4dc3-80e0-9d20c8869b6b)


Instituition Page:

![image](https://github.com/user-attachments/assets/b77feb19-a2a6-45f7-b9e3-105e5d489c9b)

Drop Down Section:

![image](https://github.com/user-attachments/assets/13f984ad-d180-44c7-b370-0d8df3766a31)

Offering Page:

![image](https://github.com/user-attachments/assets/40b74aa9-f317-43a9-918c-69944e6bd12a)

Add Offering:

![image](https://github.com/user-attachments/assets/3c6510dc-da8d-4345-9cf0-2ad558796f23)
  • Loading branch information
bidyashish authored Oct 22, 2024
1 parent 3aa8035 commit c5f2556
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ import { numericTransformer } from "@sims/sims-db/transformers/numeric.transform

/**
* Max value the offering name can have. By DB definition it is defined as
* 300 but from business perspective it should not be longer than 50.
* 300 but from business perspective it should not be longer than 100.
*/
export const OFFERING_NAME_MAX_LENGTH = 50;
export const OFFERING_NAME_MAX_LENGTH = 100;
export const OFFERING_WIL_TYPE_MAX_LENGTH = 50;

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@
"tableView": true,
"validate": {
"required": true,
"maxLength": 50,
"maxLength": 100,
"custom": "",
"customPrivate": false,
"strictDateValidation": false,
Expand Down

0 comments on commit c5f2556

Please sign in to comment.