Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current days of study/studybreaks count is 1 short of total. #1929

Closed
JasonCTang opened this issue May 8, 2023 · 0 comments
Closed

Current days of study/studybreaks count is 1 short of total. #1929

JasonCTang opened this issue May 8, 2023 · 0 comments
Assignees
@andrepestana-aot
Labels
Bug Something isn't working

Comments

@JasonCTang
Copy link
Collaborator

JasonCTang commented May 8, 2023 •
edited
Loading

Describe the Bug
The system currently does not count the start and end date inclusively when counting the # of days of study, as well as the # of days for a study break.

Actual Behaviour
The current calculation is [study end date] - [study start date].

Expected Behaviour
It should be [study end date] - [study start date] + 1.
@JasonCTang JasonCTang added the Bug Something isn't working label May 8, 2023
@andrepestana-aot andrepestana-aot self-assigned this May 25, 2023
andrepestana-aot added a commit that referenced this issue May 30, 2023
@andrepestana-aot
#1929 - Current days of study/studybreaks count is 1 short of total (#…
614a705 
…1975)

* initial commit

* added form and more tests

* changed to make dateDifference function to be always inclusive

* removed duplicate test

* changed toEqual() to toStrictEqual()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrepestana-aot andrepestana-aot

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrepestana-aot @JasonCTang