#1929 - Current days of study/studybreaks count is 1 short of total #1975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrepestana-aot
added
Bug
sh16011993
reviewed
May 29, 2023
andrepestana-aot
requested review from
andrewsignori-aot,
guru-aot,
ann-aot and
JasonCTang
| ); | ||
|
|
||
| // Assert | ||
| expect(calculatedStudyBreaksAndWeeks).toEqual({ |
There was a problem hiding this comment.
Is there a benefit of using toStrictEqual instead toEqual for these cases?
There was a problem hiding this comment.
In this case we can use .toStrictEqual because the service is creating an object literal.
Benefits of using .toEqual:
- keys with undefined properties are checked, e.g. {a: undefined, b: 2} will not equal {b: 2};
- undefined items are taken into account, e.g. [2] will not equal [2, undefined];
- array sparseness is checked, e.g. [, 1] will not equal [undefined, 1];
- object types are checked, e.g. a class instance with fields a and b will not equal a literal object with fields a and b.
I changed the comparions to .toStrictEqual. Thanks!
There was a problem hiding this comment.
Great to see some tests added to this ❤️
andrewsignori-aot
approved these changes
May 30, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
guru-aot
approved these changes
May 30, 2023
There was a problem hiding this comment.
Nice work @andrepestana-aot , thanks for adding the test cases 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dateDifferenceas all date periods will be calculated with start and end dates inclusive;getCalculatedStudyBreaksAndWeeksmethod:√ Should calculate funded study period and total days when study start and end study dates are available. (4 ms)
√ Should not calculate funded study period days and total days when study start date is not available.
√ Should not calculate funded study period days and total days when study end date is not available. (1 ms)
√ Should calculate study breaks when start and end study break dates available. (1 ms)
√ Should not calculate study breaks when start study break date is not available.
√ Should not calculate study breaks when end study break date is not available.
√ Should calculate eligible break days as a maximum of 21 days when a study break exceeds it.