-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Banners for Completed stage on Student Application Tracker #1683
Labels
Comments
andrewsignori-aot
added a commit
that referenced
this issue
Mar 10, 2023
andrewsignori-aot
added a commit
that referenced
this issue
Mar 14, 2023
…#1796) - New cards added for Student Appeal: Pending, Approved, Declined - New cards added for Offering Changed - New cards added for Scholastic Standing Changed Refactors - Renamed ApplicationCOEDetailsAPIOutDTO (and related) to EnrolmentApplicationDetailsAPIOutDTO. This is an attempt to leave "In Progress", "Enrolment" and "Completed" statuses more aligned, respectively using InProgressApplicationDetailsAPIOutDTO, EnrolmentApplicationDetailsAPIOutDTO, and CompletedApplicationDetailsAPIOutDTO. Bug fixes - Student appeal assessment record was not updated on the application current_assessment_id. - COE records were displayed multiple times when the application had multiple assessments associated. - COE confirmation sometimes failed when the application had multiple assessments associated. - Added missing note category to filters and adjusted timeline "bullets" alignment.
andrewsignori-aot
added a commit
that referenced
this issue
Mar 14, 2023
andrewsignori-aot
added a commit
that referenced
this issue
Mar 17, 2023
- Extracted the scholastic standing change type from the dynamic data and persisted as a separate column using a DB enum. - Created an error card to display the scholastic standing as an error when the change type is Student did not complete the program. Right now there is no further information about what must happen with the disbursement/COE cards nor what should actually happen with the assessment. The student who did not complete the program is the only scholastic standing change type that does not generates a new student assessment.
andrewsignori-aot
added a commit
that referenced
this issue
Mar 27, 2023
) - Fix for PIR decline throwing an error while completing the process. - Refactor application progress details to get rid of the Sonarcloud issue. - Icon spacing adjusted (@hellolynn-tbtb is aware of and approved it). - Renamed factory method saveFakeApplicationCOE to saveFakeApplicationDisbursements allowing it to be used for these E2E tests also. - Removed prefix ${ClientTypeBaseRoute.Institution} from some E2E that were wrongly added. - E2E tests for the new endpoint added for the completed status. ApplicationStudentsController(e2e)-getCompletedApplicationDetails ✓ Should throw NotFoundException when the application is not associated with the authenticated student. (390 ms) ✓ Should throw NotFoundException when the application is not in 'Completed' status. (75 ms) ✓ Should get application details when application is in 'Completed' status. (76 ms) ✓ Should get application details with scholastic standing change type when application has a scholastic standing 'Student did not complete program associated with. (60 ms) ✓ Should get application details with the most updated appeal status when the application has more than one student appeals associated with. (78 ms)
guru-aot
pushed a commit
that referenced
this issue
Mar 28, 2023
) - Fix for PIR decline throwing an error while completing the process. - Refactor application progress details to get rid of the Sonarcloud issue. - Icon spacing adjusted (@hellolynn-tbtb is aware of and approved it). - Renamed factory method saveFakeApplicationCOE to saveFakeApplicationDisbursements allowing it to be used for these E2E tests also. - Removed prefix ${ClientTypeBaseRoute.Institution} from some E2E that were wrongly added. - E2E tests for the new endpoint added for the completed status. ApplicationStudentsController(e2e)-getCompletedApplicationDetails ✓ Should throw NotFoundException when the application is not associated with the authenticated student. (390 ms) ✓ Should throw NotFoundException when the application is not in 'Completed' status. (75 ms) ✓ Should get application details when application is in 'Completed' status. (76 ms) ✓ Should get application details with scholastic standing change type when application has a scholastic standing 'Student did not complete program associated with. (60 ms) ✓ Should get application details with the most updated appeal status when the application has more than one student appeals associated with. (78 ms)
guru-aot
pushed a commit
that referenced
this issue
Mar 28, 2023
) - Fix for PIR decline throwing an error while completing the process. - Refactor application progress details to get rid of the Sonarcloud issue. - Icon spacing adjusted (@hellolynn-tbtb is aware of and approved it). - Renamed factory method saveFakeApplicationCOE to saveFakeApplicationDisbursements allowing it to be used for these E2E tests also. - Removed prefix ${ClientTypeBaseRoute.Institution} from some E2E that were wrongly added. - E2E tests for the new endpoint added for the completed status. ApplicationStudentsController(e2e)-getCompletedApplicationDetails ✓ Should throw NotFoundException when the application is not associated with the authenticated student. (390 ms) ✓ Should throw NotFoundException when the application is not in 'Completed' status. (75 ms) ✓ Should get application details when application is in 'Completed' status. (76 ms) ✓ Should get application details with scholastic standing change type when application has a scholastic standing 'Student did not complete program associated with. (60 ms) ✓ Should get application details with the most updated appeal status when the application has more than one student appeals associated with. (78 ms)
andrewsignori-aot
added a commit
that referenced
this issue
Apr 3, 2023
The success icon was not displayed for a reassessment because the check relied on the COE confirmation. Change the check to be based on the application status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Implement banners for the completed stage on Student Application Tracker.
Scenarios
Reference mockups
https://www.figma.com/file/9Om2tzLAVEoMQrjmrH4fhu/MOD-SIMS?node-id=7809%3A108528&t=WNRHHCnCKfJXwzsH-0
Acceptance Criteria
Completed (for reassessments)
Scenario: the application was in the completed stage, but then the Student requests a change and triggers a reassessment. The request for change DOES NOT generate an assessment until it is approved. If it is declined, it WILL NOT generate an assessment.
Scenario: the application was in the completed stage, but the school reports scholastic standing.
Scenario: the application was in the completed stage, but then the school requests to change offering dates.
The text was updated successfully, but these errors were encountered: