Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NRPT-620: Adding popups on LNG pipeline segments #799

Merged
merged 7 commits into from
Mar 10, 2021

Conversation

cameronpettit
Copy link
Contributor

No description provided.

Copy link
Contributor

@BcGovNeal BcGovNeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add cursor: auto to .leaflet-popup so the cursor uses default style on popups.

.leaflet-popup {
margin-bottom: 30px; // Offset so we can see the marker
}

Copy link
Contributor

@BcGovNeal BcGovNeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only issue left is #797 has the same migration as this PR. It just depends on who merges first. The later merge should have the migration removed.

@sonarcloud
Copy link

sonarcloud bot commented Mar 10, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@marklise marklise merged commit 7a38ee1 into bcgov:master Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants