Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NRPT-619: implement admin component for LNG map updates #797

Merged
merged 6 commits into from
Mar 10, 2021

Conversation

mtCarto
Copy link
Contributor

@mtCarto mtCarto commented Mar 5, 2021

@mtCarto mtCarto changed the title NRPT-619: implement admin component for LNG map info NRPT-619: implement admin component for LNG map updates Mar 5, 2021
@marklise
Copy link
Contributor

marklise commented Mar 9, 2021

When hitting Save/Publish Map Updates and one of the required fields is missing information, the alert message comes up telling you to fill them out, but then a resolver is hit. The angular router should not be using the resolver in this scenario. The alert message should popup and when dismissed go right back to the form.

@marklise
Copy link
Contributor

marklise commented Mar 9, 2021

  1. enter text in recent updates (leave length empty)
  2. hit save
  3. get alert telling you to fill out forms
  4. dismiss the dialog
  5. hit cancel map updates
  6. navigate away
  7. come back, your 'cancelled' changes are still there.

This is also likely due to the resolver being used in the previous comment.

Copy link
Contributor

@BcGovNeal BcGovNeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only issue left is #799 has the same migration as this PR. It just depends on who merges first. The later merge should have the migration removed.

@sonarcloud
Copy link

sonarcloud bot commented Mar 10, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mtCarto mtCarto merged commit 3178f10 into bcgov:master Mar 10, 2021
@mtCarto mtCarto deleted the lng-map-admin branch March 10, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants