-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NRPT-619: implement admin component for LNG map updates #797
Conversation
mtCarto
commented
Mar 5, 2021
- NRPT-619
angular/projects/admin-nrpti/src/app/communications/lng-map-info/lng-map-info.component.ts
Show resolved
Hide resolved
angular/projects/admin-nrpti/src/app/communications/lng-map-info/lng-map-info.component.ts
Show resolved
Hide resolved
When hitting Save/Publish Map Updates and one of the required fields is missing information, the alert message comes up telling you to fill them out, but then a resolver is hit. The angular router should not be using the resolver in this scenario. The alert message should popup and when dismissed go right back to the form. |
This is also likely due to the resolver being used in the previous comment. |
angular/projects/admin-nrpti/src/app/communications/lng-map-info/lng-map-info.component.ts
Outdated
Show resolved
Hide resolved
angular/projects/admin-nrpti/src/app/communications/communications.component.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Only issue left is #799 has the same migration as this PR. It just depends on who merges first. The later merge should have the migration removed.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |