Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update many packages #269

Merged
merged 5 commits into from
Jan 17, 2024
Merged

Update many packages #269

merged 5 commits into from
Jan 17, 2024

Conversation

SimonSimCity
Copy link
Collaborator

Update quite some npm packages. As far as I've tested, everything still works as expected.

  • Linting
  • Electron-DEV
  • Tests

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (e847691) 10.61% compared to head (3fb110a) 10.49%.
Report is 9 commits behind head on main.

Files Patch % Lines
components/track/TrackItem.vue 0.00% 2 Missing ⚠️
i18n.config.ts 0.00% 2 Missing ⚠️
plugins/3.applicationInsights.ts 0.00% 2 Missing ⚠️
components/sidebar/SidebarItem.vue 0.00% 1 Missing ⚠️
nuxt.config.ts 0.00% 1 Missing ⚠️
pages/search.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #269      +/-   ##
==========================================
- Coverage   10.61%   10.49%   -0.13%     
==========================================
  Files          97       97              
  Lines        4436     4488      +52     
  Branches      181      181              
==========================================
  Hits          471      471              
- Misses       3873     3925      +52     
  Partials       92       92              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-269.westeurope.3.azurestaticapps.net

Copy link
Collaborator

@sifferhans sifferhans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of questions, other than that looks good:)

components/track/TrackItem.vue Outdated Show resolved Hide resolved
"prettier-plugin-tailwindcss": "0.4.1",
"stylelint": "^15.11.0",
"stylelint-config-recommended-scss": "^13.1.0",
"nuxt": "^3.6.5",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nuxt 3.9 is already released. Is it too big of a jump from 3.6.1?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't go to 3.7.0 or further as of now. See nuxt/nuxt#25257 and the there linked research.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update will be followed up in #230

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-269.westeurope.3.azurestaticapps.net

@SimonSimCity SimonSimCity merged commit f2bc2b3 into main Jan 17, 2024
9 of 10 checks passed
@SimonSimCity SimonSimCity deleted the update-many-packages branch January 17, 2024 14:13
Copy link
Member

@kkuepper kkuepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants