Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh token functionality doesn't work properly #217

Closed
Ghostbird opened this issue Sep 19, 2023 · 7 comments
Closed

Refresh token functionality doesn't work properly #217

Ghostbird opened this issue Sep 19, 2023 · 7 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@Ghostbird
Copy link
Collaborator

Ghostbird commented Sep 19, 2023

Since #204 the app stops working at some point, and you have to manually refresh to fix it.

The good: It's cleaner than the old functionality, apparently the refresh token is used under the hood, as no browser page is needed.
The bad: There's no indication to the user what is wrong, and stuff just stops working, because under the hood every call returns 401.

We probably need to catch access token related 401s and force an access token refresh.

@SimonSimCity
Copy link
Collaborator

@Ghostbird What do you mean by "doesn't work properly"? What I've discovered so far is just #233 and a bug, that you have to reload after every successful login with redirect to the identity provider (seems to be something with vue's routing...) - this is fixed by manual refreshing. Is there anything else you know of?

@Ghostbird
Copy link
Collaborator Author

Ghostbird commented Nov 4, 2023 via email

@SimonSimCity
Copy link
Collaborator

Well, the reason I see is that there's an error when redirecting. When you reload, it's not redirecting anymore, and the page loads just fine. You should see a bunch of error messages in the console and a white page - that's it in my case. If there are any other, please let me know.

@SimonSimCity
Copy link
Collaborator

SimonSimCity commented Nov 4, 2023

I was able to nail it down to a quite small repo (https://stackblitz.com/edit/github-fn78bb) where I can reproduce this error. I'm currently waiting on the Vue team for this to be fixed: nuxt/nuxt#13309

Another issue which seems to be linked also is vuejs/core#6463

This seems to be related to Suspense being used in NuxtLayout. At least the bugs linked here point in this direction... It doesn't seem to be related to the transition there at least which I disabled (https://nuxt.com/docs/getting-started/transitions#disable-transitions)

@kkuepper kkuepper added bug Something isn't working wontfix This will not be worked on labels Nov 17, 2023
@kkuepper
Copy link
Member

I applied the wontfix label, since (hopefully) nuxt needs to do the work and not us.

@kkuepper
Copy link
Member

The nuxt and vue issues have been closed. Is this fixed? I don't think I've seen this problem recently.
If it's not fixed can you provide some reproduction steps?

@SimonSimCity
Copy link
Collaborator

Was fixed by updating vue to v3.4.0, which was already done in #269.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
No open projects
Development

No branches or pull requests

3 participants