Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh access token #204

Merged
merged 1 commit into from
Sep 16, 2023
Merged

Refresh access token #204

merged 1 commit into from
Sep 16, 2023

Conversation

Ghostbird
Copy link
Collaborator

@Ghostbird Ghostbird commented Sep 16, 2023

To solve #153

I haven't managed to test this properly yet. I tried to connect this to my own Auth0 client, to set a shorter access token time-out. That didn't work well, because that access token doesn't grant access to BMM. So you get access denied anyway.

So now I hope this PR‌ will make a build, and I can install that locally. Then I'll use that that build for a few days, to see whether it works.

@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Merging #204 (b0ec9d2) into main (7e23a20) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #204   +/-   ##
=======================================
  Coverage   97.84%   97.84%           
=======================================
  Files           5        5           
  Lines         463      463           
  Branches       84       84           
=======================================
  Hits          453      453           
  Misses         10       10           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SimonSimCity SimonSimCity force-pushed the 153-refresh-access-token branch from f383c2f to b0ec9d2 Compare September 16, 2023 13:19
@SimonSimCity
Copy link
Collaborator

Thanks for the separate commits, now I could just cherry-pick it and leave out the unrelated changes 🤗

@SimonSimCity SimonSimCity merged commit 41d4eae into main Sep 16, 2023
@SimonSimCity SimonSimCity deleted the 153-refresh-access-token branch September 16, 2023 13:35
@SimonSimCity SimonSimCity temporarily deployed to prod September 16, 2023 13:35 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants