fix(core): don't swallow input keystrokes held with a modifier - #2067
Open
bcakmakoglu wants to merge 1 commit into
Open
fix(core): don't swallow input keystrokes held with a modifier#2067bcakmakoglu wants to merge 1 commit into
bcakmakoglu wants to merge 1 commit into
Conversation
vue-flow's pan/zoom/selection/multi-selection key detection acted (and `preventDefault`-ed) even when the keydown targeted a page input while a modifier was held. Since `panActivationKeyCode` defaults to `Space` and `selectionKeyCode` to `Shift`, pressing Space in an `<input>` anywhere on the page with Shift held had its space swallowed — `useKeyPress` listens on `document`, so any input was affected. Pass `actInsideInputWithModifier: false` to those `useKeyPress` calls (the pattern already used for `deleteKeyCode`), so they defer to the focused input. Adds a regression test that types Shift+Space into an input beside the flow. Fixes #1999. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
🦋 Changeset detectedLatest commit: bf8aec3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1999.
Problem
While a modifier (e.g. Shift) is held, vue-flow's pan/zoom/selection/multi-selection key detection acted — and
preventDefault-ed — even when the keydown targeted a page<input>.panActivationKeyCodedefaults toSpaceandselectionKeyCodetoShift, anduseKeyPresslistens ondocument, so pressing Space with Shift held in any input on the page had its space swallowed (theinputevent never fired).Fix
Pass
actInsideInputWithModifier: falseto the pan/zoom/selection (ZoomPane.vue) and multi-selection (Pane.vue)useKeyPresscalls — the same option already used fordeleteKeyCode. When a modifier is held and the event targets an input, the key detection now bails beforepreventDefault, deferring to the input. Behaviour over the pane/canvas is unchanged (the option only affects input-targeted events).Verification
keyPressInsideInput.cy.ts): typesShift+Spaceinto an input beside the flow and asserts the space reaches the input. Confirmed it fails without the fix ('ab', space swallowed) and passes with it.🤖 Generated with Claude Code