refactor(core): allow adding edges with missing source or target nodes

[bcakmakoglu]

No description provided.

[changeset-bot]

🦋 Changeset detected

Latest commit: 83ff958

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@vue-flow/core	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
vue-flow-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 27, 2023 5:45pm
vue-flow-typedoc	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 27, 2023 5:45pm

[snoozbuster]

is there a way to opt-out of this behavior? I don't know why this would be useful, and in my application, it prevents the app from automatically recovering from an error. Of course, I'm working on fixing the bug that I introduced that causes edges with a missing source/target to be added in the first place - but the bug would have caused a much smaller problem with the pre-1.24.0 behavior of refusing to add the edge. I would much rather globally turn on the behavior from before this fix in my app.

[bcakmakoglu]

The behavior has been changed to match the behavior of ReactFlow as I don't want it to drift apart too much.
In RF you can add an "invalid" edge, it just won't be rendered.
It's still in your edges array and will just stay in there until it becomes valid (missing source/target node is added).
You can listen to these errors with the onError event though and just filter the edges out yourself if that's necessary but the previous behavior would've just removed elements from your state without you really knowing about it and when saved again those elements would be gone, which I don't want to decide for you.

[snoozbuster]

Makes sense, I suppose. In my application nodes are only allowed to have one outgoing edge from each handle, and we disable that handle if there is an outgoing edge, so the behavior the user gets now if there's a bug that causes an invalid edge to be added is that the handle just seems broken and a new/replacement connection can't be made. But I see your point - I guess I can re-add this error handling myself if I want.