Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify ATI Analytics #12514

Merged
merged 85 commits into from
Mar 25, 2025
Merged
Changes from 1 commit
Commits
Show all changes
85 commits
Select commit Hold shift + click to select a range
f15d732
remove front page from ati chartbear and event tracking
LilyL0u Feb 25, 2025
e10fe1a
remove front page from tracking tests
LilyL0u Feb 25, 2025
a028fc0
ad tests should use home page instead of front page
LilyL0u Feb 25, 2025
418500a
remove front page conditionals from image component
LilyL0u Feb 25, 2025
c4b7612
replace imageWithPlaceholder fixture data with Home page type
LilyL0u Feb 25, 2025
924471b
remove inclusion of front page for when psammead images are used or n…
LilyL0u Feb 25, 2025
59cba6b
radio schedule tests now use home page not front page
LilyL0u Feb 25, 2025
193a796
radio schedule utilities now use home page not front page
LilyL0u Feb 25, 2025
a6e8684
remove front page from analyticsUtils indexPage
LilyL0u Feb 25, 2025
01f28bf
remove test for absence of most read on amp front page
LilyL0u Feb 25, 2025
4f4dd17
unneeded getStatsPageIdentifier and front page used in tests for cont…
LilyL0u Feb 25, 2025
d48feef
change metadata tests to be for home page with hard coded data as the…
LilyL0u Feb 25, 2025
9353b07
replace the use of front page in header tests for home page
LilyL0u Feb 25, 2025
aba9446
test consent banner a11y yesy with home page instead of front pagecd
LilyL0u Feb 25, 2025
75dcb41
remove front page routes
LilyL0u Feb 25, 2025
66e0f2a
delete FrontPage page folder
LilyL0u Feb 25, 2025
8579af6
remove front page from atianalytics params
LilyL0u Feb 25, 2025
40286bf
this made the home page actually load
LilyL0u Feb 26, 2025
21b4fdc
maybe these changes were unnecessary, removed them and can still visi…
LilyL0u Feb 26, 2025
a651a12
fix server tests to be for home page not front page
LilyL0u Feb 26, 2025
5e55ea2
try to fix front page bundle size errors
LilyL0u Feb 26, 2025
2df457a
utils regex tests and code change but homePageDataPAth left in
LilyL0u Feb 26, 2025
b1c482c
remove cypress front page references
LilyL0u Feb 26, 2025
a75f795
remove front page import from pages mocks folder
LilyL0u Feb 26, 2025
e42aab6
prettier
LilyL0u Feb 26, 2025
085bf2c
bundleSize error message, can't run test without pushing
LilyL0u Feb 26, 2025
f01b3cf
/kyrgyz and similar are valid routes for home pages
LilyL0u Feb 26, 2025
e5fa6f4
snapshot update to homePageTitle from frontPageTitle
LilyL0u Feb 26, 2025
d05bcc2
analytics utils tests to check home page not front page
LilyL0u Feb 26, 2025
e881e9a
someone needs to work out if we can delete the home page data path as…
LilyL0u Feb 26, 2025
857dec7
update routes readme to be home page instead of front page
LilyL0u Feb 26, 2025
ef589d9
bulletin container uses home page not front page
LilyL0u Feb 26, 2025
594b870
constructDataFilePath
LilyL0u Feb 26, 2025
26e520a
linked data tests
LilyL0u Feb 26, 2025
bd65188
test name
LilyL0u Feb 26, 2025
365e44c
delete frontpage references from getInitialData test file
louisearchibald Feb 27, 2025
0421f75
Merge branch 'latest' into WORLDSERVICE-37-delete-frontpage-and-all-a…
louisearchibald Feb 27, 2025
54a61de
Merge branch 'WORLDSERVICE-37-delete-frontpage-and-all-associated-cod…
louisearchibald Feb 27, 2025
9014ad9
remove front page references from constructPageFetchUrl
louisearchibald Feb 27, 2025
2436143
Merge branch 'latest' into WORLDSERVICE-37-delete-frontpage-and-all-a…
amoore108 Feb 27, 2025
9f529c8
Delete buildParams.ts
amoore108 Feb 27, 2025
cf4a60f
Component removals
amoore108 Feb 27, 2025
956a260
Update getInitialData.test.jsx
amoore108 Feb 27, 2025
b96cac0
Remove frontPage from cypress settings
amoore108 Feb 27, 2025
dca1c54
Remove fixture data
amoore108 Feb 27, 2025
cdfbd03
Merge branch 'latest' into WORLDSERVICE-37-delete-frontpage-and-all-a…
amoore108 Feb 28, 2025
858ca08
Delete `Bulletin`
amoore108 Feb 28, 2025
de9a3ef
Remove `analyticsUrls/indexPage` function
amoore108 Feb 28, 2025
a0cf142
Merge branch 'latest' into WORLDSERVICE-37-delete-frontpage-and-all-a…
amoore108 Feb 28, 2025
a93024a
Merge branch 'latest' into WORLDSERVICE-37-delete-frontpage-and-all-a…
amoore108 Feb 28, 2025
7a97dbe
Merge branch 'latest' into WORLDSERVICE-37-delete-frontpage-and-all-a…
amoore108 Mar 3, 2025
b8669d3
Merge branch 'latest' into WORLDSERVICE-37-delete-frontpage-and-all-a…
amoore108 Mar 3, 2025
b85bd1e
Regex tidy
amoore108 Mar 3, 2025
0ee3ea5
Remove `index` from Chartbeat
amoore108 Mar 3, 2025
a5ba9ec
Regex test revert
amoore108 Mar 3, 2025
b8cc61f
Delete commented out test routes
amoore108 Mar 3, 2025
ee3abfe
Merge branch 'latest' into WORLDSERVICE-37-delete-frontpage-and-all-a…
amoore108 Mar 4, 2025
eec965e
Merge branch 'latest' into WORLDSERVICE-37-delete-frontpage-and-all-a…
amoore108 Mar 4, 2025
8c6a08d
Update regex env test
amoore108 Mar 4, 2025
3b9af7c
Merge branch 'latest' into WORLDSERVICE-37-delete-frontpage-and-all-a…
amoore108 Mar 4, 2025
e94fe83
Merge branch 'latest' into WORLDSERVICE-37-delete-frontpage-and-all-a…
pvaliani Mar 4, 2025
41d76fa
remove unused launchdates script
pvaliani Mar 4, 2025
86a94f7
remove reference to launchdates.js in codeclimate yaml
pvaliani Mar 4, 2025
ebd8575
Update `frontPageRadioSchedule` references to `homePageRadioSchedule`
amoore108 Mar 4, 2025
9247663
Merge branch 'latest' into WORLDSERVICE-37-delete-frontpage-and-all-a…
amoore108 Mar 4, 2025
2fb8a9a
Merge branch 'latest' into WORLDSERVICE-37-delete-frontpage-and-all-a…
amoore108 Mar 5, 2025
47db144
Merge branch 'latest' into WORLDSERVICE-37-delete-frontpage-and-all-a…
amoore108 Mar 5, 2025
842b93a
Merge branch 'latest' into WORLDSERVICE-37-delete-frontpage-and-all-a…
amoore108 Mar 5, 2025
2aead39
Merge branch 'latest' into WORLDSERVICE-37-delete-frontpage-and-all-a…
amoore108 Mar 6, 2025
ab78c55
Merge branch 'latest' into WORLDSERVICE-37-delete-frontpage-and-all-a…
amoore108 Mar 10, 2025
da8dd85
Update bundleSizeConfig.js
amoore108 Mar 10, 2025
2f75016
Merge branch 'latest' into WORLDSERVICE-37-delete-frontpage-and-all-a…
eagerterrier Mar 10, 2025
007ffef
Merge branch 'latest' into WORLDSERVICE-37-delete-frontpage-and-all-a…
amoore108 Mar 13, 2025
899a7b0
Merge branch 'latest' into WORLDSERVICE-37-delete-frontpage-and-all-a…
amoore108 Mar 13, 2025
6df2b52
Update bundleSizeConfig.js
amoore108 Mar 13, 2025
a585265
Update bundleSizeConfig.js
amoore108 Mar 13, 2025
323de01
Merge branch 'latest' into WORLDSERVICE-37-delete-frontpage-and-all-a…
amoore108 Mar 13, 2025
05f5167
Simplify ATI Analytics logic now that all page types have been migrat…
karinathomasbbc Mar 13, 2025
78085f7
Further cleanup
karinathomasbbc Mar 13, 2025
4071872
Fix type error
karinathomasbbc Mar 13, 2025
87cffdf
Merge branch 'latest' of github.com:bbc/simorgh into simplify-ati-ana…
karinathomasbbc Mar 19, 2025
dd475c9
Merge branch 'latest' into simplify-ati-analytics
karinathomasbbc Mar 20, 2025
d8e3cd3
Merge branch 'latest' into simplify-ati-analytics
karinathomasbbc Mar 20, 2025
7cd31d8
Merge branch 'latest' into simplify-ati-analytics
karinathomasbbc Mar 24, 2025
2845ad6
Merge branch 'latest' into simplify-ati-analytics
karinathomasbbc Mar 25, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
radio schedule utilities now use home page not front page
LilyL0u committed Feb 25, 2025

Verified

This commit was signed with the committer’s verified signature.
karinathomasbbc Karina Thomas
commit 193a796d4f32074860427d7e359d56335b977a3e
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@ import React, { useMemo } from 'react';
import { BrowserRouter } from 'react-router-dom';
import { RequestContextProvider } from '#contexts/RequestContext';
import { ToggleContext } from '#contexts/ToggleContext';
import { FRONT_PAGE } from '#app/routes/utils/pageTypes';
import { HOME_PAGE } from '#app/routes/utils/pageTypes';
import { ServiceContextProvider } from '../../../../contexts/ServiceContext';
import RadioScheduleContainer from '..';

@@ -27,7 +27,7 @@ const RadioSchedulesWithContext = ({
<ToggleContext.Provider value={toggleContextValue}>
<RequestContextProvider
isAmp={isAmp}
pageType={FRONT_PAGE}
pageType={HOME_PAGE}
service={service}
pathname={`/${service}`}
timeOnServer={Date.now()}

Unchanged files with check annotations Beta

statsDestination: requestContext.statsDestination,
};
const frontPage = {

Check failure on line 46 in src/app/components/ATIAnalytics/params/frontPage/buildParams.test.ts

GitHub Actions / cypress-run (18.x)

'frontPage' is declared but its value is never read.

Check failure on line 46 in src/app/components/ATIAnalytics/params/frontPage/buildParams.test.ts

GitHub Actions / build (18.x)

'frontPage' is declared but its value is never read.
metadata: {
analyticsLabels: {
counterName: 'service.page',
buildPageATIParams,
buildPageReverbParams,
} from './buildParams';
import {

Check failure on line 28 in src/app/components/ATIAnalytics/params/index.ts

GitHub Actions / cypress-run (18.x)

All imports in import declaration are unused.

Check failure on line 28 in src/app/components/ATIAnalytics/params/index.ts

GitHub Actions / build (18.x)

All imports in import declaration are unused.
buildIndexPageATIParams,
buildIndexPageATIUrl,
} from './frontPage/buildParams';
import { Helmet } from 'react-helmet';
import {
ARTICLE_PAGE,
FRONT_PAGE,

Check failure on line 5 in src/app/components/Metadata/index.test.tsx

GitHub Actions / cypress-run (18.x)

Module '"#app/routes/utils/pageTypes"' has no exported member 'FRONT_PAGE'.

Check failure on line 5 in src/app/components/Metadata/index.test.tsx

GitHub Actions / build (18.x)

Module '"#app/routes/utils/pageTypes"' has no exported member 'FRONT_PAGE'.
STORY_PAGE,
MEDIA_ASSET_PAGE,
PHOTO_GALLERY_PAGE,
import { data as pidginMostReadData } from '../../../../data/pidgin/mostRead/index.json';
import serbianLatMostReadData from '../../../../data/serbian/mostRead/lat.json';
import {
FRONT_PAGE,

Check failure on line 7 in src/app/components/MostRead/index.test.tsx

GitHub Actions / cypress-run (18.x)

Module '"../../routes/utils/pageTypes"' has no exported member 'FRONT_PAGE'.

Check failure on line 7 in src/app/components/MostRead/index.test.tsx

GitHub Actions / build (18.x)

Module '"../../routes/utils/pageTypes"' has no exported member 'FRONT_PAGE'.
STORY_PAGE,
ARTICLE_PAGE,
CORRESPONDENT_STORY_PAGE,
import { PageTypes, Services } from '#app/models/types/global';
import { ARTICLE_PAGE, FRONT_PAGE } from '#app/routes/utils/pageTypes';

Check failure on line 2 in src/app/contexts/RequestContext/getStatsPageIdentifier/index.test.ts

GitHub Actions / cypress-run (18.x)

Module '"#app/routes/utils/pageTypes"' has no exported member 'FRONT_PAGE'.

Check failure on line 2 in src/app/contexts/RequestContext/getStatsPageIdentifier/index.test.ts

GitHub Actions / build (18.x)

Module '"#app/routes/utils/pageTypes"' has no exported member 'FRONT_PAGE'.
import getStatsPageIdentifier from '.';
describe('getStatsPageIdentifier', () => {
import { PageTypes, Services } from '#app/models/types/global';
import { ARTICLE_PAGE, FRONT_PAGE } from '../../../routes/utils/pageTypes';

Check failure on line 2 in src/app/contexts/RequestContext/getStatsPageIdentifier/index.ts

GitHub Actions / cypress-run (18.x)

Module '"../../../routes/utils/pageTypes"' has no exported member 'FRONT_PAGE'.

Check failure on line 2 in src/app/contexts/RequestContext/getStatsPageIdentifier/index.ts

GitHub Actions / build (18.x)

Module '"../../../routes/utils/pageTypes"' has no exported member 'FRONT_PAGE'.
type Props = {
pageType: PageTypes;
import React, { useContext } from 'react';
import { render } from '@testing-library/react';
import { FRONT_PAGE } from '#app/routes/utils/pageTypes';

Check failure on line 3 in src/app/contexts/RequestContext/index.test.tsx

GitHub Actions / cypress-run (18.x)

Module '"#app/routes/utils/pageTypes"' has no exported member 'FRONT_PAGE'.

Check failure on line 3 in src/app/contexts/RequestContext/index.test.tsx

GitHub Actions / build (18.x)

Module '"#app/routes/utils/pageTypes"' has no exported member 'FRONT_PAGE'.
import * as getStatsDestination from './getStatsDestination';
import * as getStatsPageIdentifier from './getStatsPageIdentifier';
import * as getOriginContext from './getOriginContext';