Simplify ATI Analytics #12514
Merged
Simplify ATI Analytics #12514
+20
−563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… same data is not present in the home page pagedata in the same way
… it still works locally but not live (live uses bff)
…ed and use ATI Data instead of page data
Base automatically changed from
WORLDSERVICE-37-delete-frontpage-and-all-associated-code
to
latest
March 19, 2025 12:47
karinathomasbbc
commented
Mar 19, 2025
| @@ -384,17 +382,6 @@ describe('ATIAnalytics params', () => { | |||
| }), | |||
| ); | |||
| }); | |||
| it.each([HOME_PAGE, ERROR_PAGE, LIVE_PAGE])( | |||
There was a problem hiding this comment.
I removed this test because it was using data (instead of atiData). Perhaps I need to reinstate it, but for ERROR_PAGE and LIVE_PAGE (need confirmation on whether LIVE_PAGE is valid or not)
emilysaffron
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall changes
Simplifies ATI analytics logic, now that all pages have been migrated to the BFF
Code changes
Testing