Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storybook, npm, webpack setup - draft #184

Merged
merged 2 commits into from
Aug 21, 2019
Merged

Conversation

pietrop
Copy link
Contributor

@pietrop pietrop commented Aug 14, 2019

Is your Pull Request request related to another issue in this repository ?

mostly based on #135 but also related to #130, #129

Describe what the PR does

Based on PR #135 provides a guide for setting up storybook with npm to publish components. Drafted for bbc/digital-paper-edit-storybook setup.

State whether the PR is ready for review or whether it needs extra work

Ready for review by @jamesdools @emettely
cc @allishultes

Additional context

NA

Just a draft, see if it makes sense, and feel free, to change/clarify. It be good to capture this setup if we are going to re-use in DPE etc..

@pietrop pietrop requested review from emettely and jamesdools August 14, 2019 16:43
@pietrop pietrop self-assigned this Aug 14, 2019
@pietrop pietrop changed the title draft storybook - npm -webpack setup - draft Aug 14, 2019
@pietrop pietrop changed the title storybook - npm -webpack setup - draft storybook, npm, webpack setup - draft Aug 14, 2019
Copy link

@allishultes allishultes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall - I haven't tried to set it up but have left a few comments. There's some editing (spelling, grammar) I'd do too but this is ultimately clear.

docs/guides/storybook-npm-setup.md Outdated Show resolved Hide resolved
docs/guides/storybook-npm-setup.md Outdated Show resolved Hide resolved
Copy link
Contributor

@emettely emettely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are going to mention historical changes, you would need to describe it more - not much how and why, so when you mention babel I'm a bit puzzled as to why you mention it.

docs/guides/storybook-npm-setup.md Outdated Show resolved Hide resolved
docs/guides/storybook-npm-setup.md Outdated Show resolved Hide resolved
docs/guides/storybook-npm-setup.md Outdated Show resolved Hide resolved
@emettely emettely merged commit 0713129 into master Aug 21, 2019
@emettely emettely deleted the storybook-npm-setup-guides branch August 21, 2019 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants