-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monorepo refactor #130
Monorepo refactor #130
Conversation
…128) * moved TimedTextEditor and TranscriptEditor to packages also created stories, and package.json for each, but can't test them in storybook coz they have dependencies on adapters in Util folder * moved Util and demdemo app * got storybook working * added demo app to storybook * mend * Fix: commenting out demo
* cleaned up adapters * changed folder structure * fixed timecode converter duplice module * made all packages private except for TranscriptEditor
I am sold on the storybook, but some things to figure out are, do we really need Lerna? Argument for removing Lerna in the monorepo setup.
Will do a separate spike from this branch/PR to show what it would look like without lerna. |
* got storybook working tests not working yet * fixed tests using jest, and removed CRA dependency, updated babel config for babel 7 and stubbed css files for jest tests for css node modules * Added support for demo app in storybook * fixed eslint CRA had it's own linter internally, so added linting + dependencies * cleaned up export scripts in package.json * updated README * finalised refactor see PR description for more details * rename demo app editor to demoTranscript * bringing back style lint, and fixing lint in storybook config * updated with current master AWS adapter * linting * fix #132 playtime displaied double playtime on display is double of actual total playtime * temporary fix #73 monospace duration and current time in media player to stop moving while playing
Is your Pull Request request related to another issue in this repository ?
#122
Describe what the PR does
Restructures the codebase to be more modular, introducing storybook
State whether the PR is ready for review or whether it needs extra work
still in draft