Video component #28
Merged
Video component #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emettely
commented
Sep 17, 2019
packages/components/PreviewCanvas/VideoContextPreview/Canvas.js
Outdated
Show resolved
Hide resolved
packages/components/PreviewCanvas/VideoContextPreview/VideoContextProgressBar.test.js
Outdated
Show resolved
Hide resolved
packages/components/PreviewCanvas/VideoContextPreview/VideoContextProgressBar.test.js
Outdated
Show resolved
Hide resolved
…textProgressBar.test.js
…textProgressBar.test.js
allishultes
approved these changes
Sep 18, 2019
There was a problem hiding this comment.
Looks good - not sure I've made this comment before, but noticing we're using Bootstrap classes to style more than just the grid and also inline styles. We might want to refactor CSS to a different format at some point in the future (but think we can worry about it later)
Co-Authored-By: Alli Shultes <[email protected]>
…textProgressBar.js
…textProgressBar.js
…textProgressBar.js
…textProgressBar.js
…textProgressBar.js
…textProgressBar.js
Yup good point - leaving that to a later point but agree it is something we can look at. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your Pull Request request related to another issue in this repository ?
#23
Describe what the PR does
Refactor work and creates a video component in the storybook, using video context.
State whether the PR is ready for review or whether it needs extra work
ready
Additional context