Skip to content

Component: Preview Canvas #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 of 14 tasks
allishultes opened this issue Sep 4, 2019 · 0 comments
Closed
4 of 14 tasks

Component: Preview Canvas #23

allishultes opened this issue Sep 4, 2019 · 0 comments
Labels
generic component A non-workspace component for the storybook

Comments

@allishultes
Copy link
Contributor

allishultes commented Sep 4, 2019

Is your feature request related to a problem? Please describe.

We would like the components of the Preview Canvas to be refactored and migrated to the Storybook.

Describe the solution you'd like

  • The component must take in elements and actions.
  • The preview canvas is available in storybook as an isolated component
  • It is published on NPM.
  • It is removed from client.

Plus, refactors:

Screenshot 2019-09-04 at 07 53 33

Describe alternatives you've considered

NA

Additional context

Link to DPE Client Code

Checklist

  • Fork the repository (external contributors)
  • Create a branch with a meaningful name eg component-<component name>
  • Add automated tests*
  • Test suite passes (npm run test)
  • Code is linted (npm run lint)
  • Update documentation and QA docs - see updating the documentation*
  • re-factoring for code quality and readability
  • Setup your PR for review (start with a draft PR)
  • Demonstrated (attach link or image)

*where appropriate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generic component A non-workspace component for the storybook
Projects
None yet
Development

No branches or pull requests

2 participants