Prefix name for jvm_maven_import_external with "jar_jar_" to avoid name collisions #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me collisions Such collisions may appear when jar_jar's dependencies are also included by other plugins, like rules_jvm_external. The generated structure for those dependencies included with those plugins may be different than expected by us and it can cause build errors (e.g. BUILD file not found). Prefix the name for jvm_maven_import_external with "jar_jar_", so that no collisions occur.
|
seems like it should be fine. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such collisions may appear when jar_jar's dependencies are also included
by other plugins, like rules_jvm_external.
The generated structure for those dependencies included with those plugins
may be different than expected by us and it can cause build errors
(e.g. BUILD file not found).
Prefix the name for jvm_maven_import_external with "jar_jar_", so that no
collisions occur.