Skip to content

Commit

Permalink
Prefix name for jvm_maven_import_external with "jar_jar_" to avoid na…
Browse files Browse the repository at this point in the history
…me collisions (#16)

Such collisions may appear when jar_jar's dependencies are also included
by other plugins, like rules_jvm_external.
The generated structure for those dependencies included with those plugins
may be different than expected by us and it can cause build errors
(e.g. BUILD file not found).

Prefix the name for jvm_maven_import_external with "jar_jar_", so that no
collisions occur.
  • Loading branch information
gergelyfabian authored Jul 8, 2020
1 parent 20dbf71 commit 171f268
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion jar_jar.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def _mvn_name(coord):
return nodash

def _mvn_jar(coord, sha, bname, servers):
nm = _mvn_name(coord)
nm = "jar_jar_" + _mvn_name(coord)
jvm_maven_import_external(
name=nm,
artifact=coord,
Expand Down

0 comments on commit 171f268

Please sign in to comment.