Skip to content

Remove propagating cc libs with objc provider #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
keith wants to merge 1 commit into from
Closed

Remove propagating cc libs with objc provider #420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions swift/internal/compiling.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ load(":providers.bzl", "SwiftInfo", "create_swift_info")
load(":toolchain_config.bzl", "swift_toolchain_config")
load(
":utils.bzl",
"collect_cc_libraries",
"compact",
"get_providers",
"struct_fields",
Expand Down Expand Up @@ -1483,20 +1482,8 @@ def new_objc_provider(
"uses_swift": True,
}

# The link action registered by `apple_binary` only looks at `Objc`
# providers, not `CcInfo`, for libraries to link. Until that rule is
# migrated over, we need to collect libraries from `CcInfo` (which will
# include Swift and C++) and put them into the new `Objc` provider.
transitive_cc_libs = []
for cc_info in get_providers(deps, CcInfo):
static_libs = collect_cc_libraries(
cc_info = cc_info,
include_static = True,
)
transitive_cc_libs.append(depset(static_libs, order = "topological"))
objc_provider_args["library"] = depset(
static_archives,
transitive = transitive_cc_libs,
order = "topological",
)

Expand Down