Remove propagating cc libs with objc provider#420
Closed
keith wants to merge 1 commit intobazelbuild:masterfrom
Closed
Remove propagating cc libs with objc provider#420keith wants to merge 1 commit intobazelbuild:masterfrom
keith wants to merge 1 commit intobazelbuild:masterfrom
Conversation
When using a rule tree like this: ``` ios_static_framework swift_library objc_library cc_library ``` Including these libraries in the objc provider leads them to being included twice in the produced static binary. It appears the comment here was outdated and that apple_binary does collect libraries directly from the CcInfo
keith
force-pushed
the
ks/remove-propagating-cc-libs-with-objc-provider
branch
from
43f6cd2 to
9228117
Compare
Member
Author
|
This breaks other cases where you have more objc libs that depend on the swift libs, now tracking this issue in bazelbuild/bazel#11223 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a rule tree like this:
Including these libraries in the objc provider leads them to being
included twice in the produced static binary. It appears the comment
here was outdated and that apple_binary does collect libraries directly
from the CcInfo.