Move check for LLVM toolchain outside of repository_rule #1090
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking
CC=clang
in the implementation of therepository_rule
doesn't work when using--incompatible_enable_cc_toolchain_resolution
(for example when using https://github.com/grailbio/bazel-toolchain to bring a hermetic LLVM toolchain).Moving the check for LLVM the
repository_rule
to the Swift toolchain impl used by allrule
s instead solves this issue.I tested that the check (the failure message) is triggered on Linux with:
gcc
installedWORKSPACE
but without--incompatible_enable_cc_toolchain_resolution
Fixes #991