Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Move check for LLVM toolchain outside of repository_rule (#1090)
Checking `CC=clang` in the implementation of the `repository_rule` doesn't work when using `--incompatible_enable_cc_toolchain_resolution` (for example when using https://github.com/grailbio/bazel-toolchain to bring a hermetic LLVM toolchain). Moving the check for LLVM the `repository_rule` to the Swift toolchain impl used by all `rule`s instead solves this issue. I tested that the check (the failure message) is triggered on Linux with: - only `gcc` installed - a LLVM toolchain configured in `WORKSPACE` but without `--incompatible_enable_cc_toolchain_resolution` Fixes #991
- Loading branch information