Cleanup platform configurations #399
Conversation
|
Ok the PR LGTM but I want to find a better title for the commit. Maybe |
|
@damienmg Is that preferred over the current commit message?
I'm happy to change it. I've definitely noticed I've gotten lazy in my commit messages 😅 |
|
It not only add unix platform, but also fix the |
|
Oh man! I totally forgot I added that here, I'll close #402. Sorry about that, haven't been sleeping well 😅 |
|
Anyway, what do you think about the name of this PR? |
|
Thanks LGTM! |
|
@damienmg Is it the name of the PR that shows as the commit message? I've updated the name and top comment as well as the commit message for this PR. Thoughts? |
|
Yes if you create a PR with a single commit, the title and description of that PR is going to be the title and description of the commit (we can change it when we do the merge). If there is multiple commit, it create a bullet list with all the commit title as the commit description. |
…#407) This PR adds `rust_workspace` which is meant to define transitive dependencies as well as cleans up some duplicate files that were in the root of the project but only used by examples. ## Updated documentation Note the updated documentation in [docs/index.md](https://github.com/UebelAndre/rules_rust/blob/workspace-structure/docs/index.md) ## Added `bazel_skylib` to `rust_repositories` It appears there are some uses of `bazel_skylib` within these rules but there aren't really any guarantees that that repository is available. This may be my fault with the changes made in #399 to [@io_bazel_rules_rust//rust/platform:platform.bzl](https://github.com/bazelbuild/rules_rust/blob/master/rust/platform/platform.bzl#L3) but I feel the `bazel_skylib` dependency should be conditionally added ## Added `rust_workspace` I feel this is much nicer on the users's end as it gives them a single place to go to look at dependencies and is nicer on the repo because it means dependencies can more easily updated. I'm not the biggest fan of the name `rust_workspace` so if this was an acceptable concept, I'm happy to take suggestions on what the name should be called.
3 participants
This is a slight cleanup pull request but also adds the
@io_bazel_rules_rust//rust/platform:unixand@io_bazel_rules_rust//rust/platform:wasm32-unknown-unknowntargets