Reorganized sub-workspace dependencies #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
damienmg
reviewed
Sep 9, 2020
Collaborator
damienmg
left a comment
damienmg
left a comment
There was a problem hiding this comment.
Most looks good, I just have 2 remarks (and a typo in the title of the PR).
damienmg
changed the title
damienmg
changed the title
UebelAndre
changed the title
damienmg
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains various cleanup/quality-of-life improvements for the repository by clearly grouping and defining dependencies for the
docsandexamplesworkspaces. Ultimately, the files that are created in here can be moved entirely into their neighboringWORKSPACEfiles once bazelbuild/bazel#1943 has been closed.