Reduce number of default supported_platform_triples for crate_universe
#3239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UebelAndre
force-pushed
the
crate_universe_platforms
branch
from
d8fc77e to
07dc52b
Compare
Collaborator
Author
|
@illicitonion I'm curious if this should just be a mandatory field. It impacts the lockfile so this change is gonna require everyone to repin. It previously changed anytime someone added a new platform and this would trigger another change. You'll also notice I only updated the bzlmod extension. I think |
illicitonion
approved these changes
Feb 5, 2025
Collaborator
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
Do we want to do this for WORKSPACE too?
Collaborator
Author
Updated! |
UebelAndre
force-pushed
the
crate_universe_platforms
branch
from
856be91 to
ad3990b
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
to dfinity/ic
that referenced
this pull request
May 16, 2025
This lists x86-darwin as a platform supported by rules_rust. This seems to have been removed [upstream](bazelbuild/rules_rust#3239).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should save substantial time for users of
crate_universeas they don't need to do splicing for platforms they're not going to use. It's still recommended users explicitly setsupported_platform_triplesbut my expectation with this change is that it covers most of the bases for users to still provide them with a sufficiently responsive experience compared to the 34 platforms that used to be in splicing.