Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING CHANGE] upgrade x/tools to 0.13.0 #3702

Closed
wants to merge 1 commit into from

Conversation

tyler-french
Copy link
Contributor

@tyler-french tyler-french commented Sep 18, 2023

This PR introduces the breaking changes of upgrading x/tools to 0.13.0

Downstream users who are not able to upgrade will need to apply the following patch: x_tools_old.patch

Related comment: #3640 (comment)

Resolves #3640

  1. This PR needs to be merged.
  2. We need to release prepare release 0.42.0 #3697 0.42.0
  3. Then, we need to upgrade x/tools and rules_go simultaneously in https://github.com/bazelbuild/bazel-gazelle
  4. Then, we need to release a new version of Gazelle.

We will need to send out communication that downstream users will need to upgrade all 3 simultaneously, or patch rules_go with x_tools_old.patch

@sluongng
Copy link
Contributor

Including the patch into the repo might be a brilliant move. We could add into the release note an instruction on how to consume the patch in some scenarios.

@tyler-french
Copy link
Contributor Author

Including the patch into the repo might be a brilliant move. We could add into the release note an instruction on how to consume the patch in some scenarios.

Great idea. I haven't had a chance to get back and fix the builds, but we should probably at least include the patch download link with the release

@hawkingrei
Copy link
Contributor

In fact, x/tools is important for the linter such as golangci-linter. We haven't updated to the latest version of the linter for a long time, and we are also unable to update to the latest version of grpc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nogo_main fail to build when to upgrade golang.org/x/tools
3 participants