Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare release 0.42.0 #3697

Merged
merged 1 commit into from
Sep 25, 2023
Merged

prepare release 0.42.0 #3697

merged 1 commit into from
Sep 25, 2023

Conversation

tyler-french
Copy link
Contributor

@tyler-french tyler-french commented Sep 15, 2023

This PR does not upgrade x/tools because there is a backward incompatible change that will force downstream users to upgrade.

external/io_bazel_rules_go/go/tools/builders/nogo_main.go:237:11: not enough arguments in call to pkg.facts.Encode
        have ()
        want (bool)
external/io_bazel_rules_go/go/tools/builders/nogo_main.go:399:54: not enough arguments in call to facts.NewDecoder(pkg.types).Decode
        have (func(pkg *types.Package) ([]byte, error))
        want (bool, func(pkgPath string) ([]byte, error))

We should wait to upgrade x/tools as it is pretty invasive: #3702

@tyler-french tyler-french force-pushed the rules-go-42 branch 4 times, most recently from 6ea78a7 to ab269a2 Compare September 18, 2023 20:15
@tyler-french tyler-french marked this pull request as ready for review September 18, 2023 21:01
@tyler-french tyler-french marked this pull request as draft September 18, 2023 21:21
@tyler-french tyler-french marked this pull request as ready for review September 18, 2023 21:49
@fmeum fmeum enabled auto-merge (squash) September 25, 2023 10:21
@fmeum fmeum merged commit 6c8cc80 into bazelbuild:master Sep 25, 2023
2 checks passed
@tyler-french tyler-french deleted the rules-go-42 branch December 23, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants