Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.0.0] "I/O exception during sandboxed execution" "Directory not empty" with --experimental_reuse_sandbox_directories #19959

Merged
merged 1 commit into from
Oct 30, 2023
Merged

[7.0.0] "I/O exception during sandboxed execution" "Directory not empty" with --experimental_reuse_sandbox_directories #19959

merged 1 commit into from
Oct 30, 2023

Commits on Oct 26, 2023

  1. Fix bug in reuse_sandbox_directories 

    bazelbuild#19935 gives a clear repro. The problem appears when a stashed sandbox
contains a directory whose same path is a regular file in a later
execution. If we try to reuse the stashed sandbox we trigger an error if
the old directory contained any files.

This was due to simply calling delete() without checking first if it
was a directory. The fix is to call deleteTree() instead in those cases.
directory.

Fixes bazelbuild#19935

RELNOTES:none
PiperOrigin-RevId: 576889004
Change-Id: I73b145cd574b83c473ffaccd90b675eb5f086c0e
    @oquenchil @bazel-io
    oquenchil authored and bazel-io committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    da047f8 View commit details
    Browse the repository at this point in the history